Source/modules/websockets/MainThreadWebSocketChannel.cpp - Issue 124003003: Add ascii() / latin1() / utf8() methods to AtomicString to avoid having to call string()

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/modules/websockets/MainThreadWebSocketChannel.cpp

Issue 124003003: Add ascii() / latin1() / utf8() methods to AtomicString to avoid having to call string() (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: Created 6 years, 12 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: Source/modules/websockets/MainThreadWebSocketChannel.cpp

diff --git a/Source/modules/websockets/MainThreadWebSocketChannel.cpp b/Source/modules/websockets/MainThreadWebSocketChannel.cpp

index 96e20c227ea0586b75d860927feb50e4128ba6bc..ec24aa2180e0fc5d60f0d40dface6418ba699c24 100644

--- a/Source/modules/websockets/MainThreadWebSocketChannel.cpp

+++ b/Source/modules/websockets/MainThreadWebSocketChannel.cpp

@@ -128,7 +128,7 @@ String MainThreadWebSocketChannel::extensions()

WebSocketChannel::SendResult MainThreadWebSocketChannel::send(const String& message)

{

WTF_LOG(Network, "MainThreadWebSocketChannel %p send() Sending String '%s'", this, message.utf8().data());

- CString utf8 = message.utf8(String::StrictConversionReplacingUnpairedSurrogatesWithFFFD);

+ CString utf8 = message.utf8(StrictUTF8ConversionReplacingUnpairedSurrogatesWithFFFD);

enqueueTextFrame(utf8);

processOutgoingFrameQueue();

// m_channel->send() may happen later, thus it's not always possible to know whether

« no previous file with comments | « Source/modules/mediasource/MediaSourceBase.cpp ('k') | Source/modules/websockets/NewWebSocketChannelImpl.cpp » ('j') | no next file with comments »