Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(250)

Issue 1239333002: Reenable yasm for Android x86 and x86-64 on Linux (Closed)

Created:
5 years, 5 months ago by msarett
Modified:
5 years, 5 months ago
Reviewers:
bungeman-skia, djsollen
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@master
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

Reenable yasm for Android x86 and x86-64 on Linux host It turns out that gyp (kind of) has support for cross compiling with a different host and target. We simply need to specify CC_host and CC_target instead of CC. Making this change allows us to compile yasm on a Linux host for Android. We run into problems on Mac because the linker on a Mac host requires different command line arguments than the linker on the Android target. In looking through the code for gyp itself and speaking to Ben, it doesn't appear to me that gyp supports passing different arguments to host and target linkers. I would imagine that we would have similar problems on Windows. Below is a link to a CL that would fix this issue in gyp. It looks like it has been dropped for a long time. Thanks to Ben for this link! https://chromiumcodereview.appspot.com/10795044/ Also I'm adding a link to the build instructions for Chrome (thanks again Ben). It looks like they only support building for Android from Linux. https://code.google.com/p/chromium/wiki/AndroidBuildInstructions My next steps are: 1) Getting in touch with Torne or someone else with gyp to see if people are aware of this issue or interested in fixing it. 2) Deciding if skia should care about this issue. 3) Deciding if skia should work around this issue. It'd be really great to hear your thoughts on (2) and (3). My first thought is that we shouldn't care because, as long as we always compile the production copy of skia for Android on Linux, we will get the fast code. Is this a valid conclusion? Is there a way to write Android apps on Mac that accidentally use the slower code? If we do care, there are workarounds: For Mac, we can check in a yasm binary - it's a little smaller than the one I am deleting in this CL :-/ For Windows, we *might* be able to use the yasm.exe binary already in externals (we get this from DEPS because this is how chromium uses yasm on Windows). Are there other platforms that we care about? Let me know what you think! BUG=skia:4028 DOCS_PREVIEW= https://skia.org/?cl=1239333002 Committed: https://skia.googlesource.com/skia/+/cf2a6a47e4db5682798fe46f9e3ef14a27ff4b2b

Patch Set 1 : #

Patch Set 2 : Only enable on Linux #

Patch Set 3 : #

Patch Set 4 : Adding documentation #

Unified diffs Side-by-side diffs Delta from patch set Stats (+74 lines, -29 lines) Patch
M gyp/libjpeg-turbo.gyp View 1 3 chunks +13 lines, -10 lines 0 comments Download
M gyp/yasm.gyp View 1 chunk +1 line, -0 lines 0 comments Download
M platform_tools/android/bin/utils/setup_toolchain.sh View 1 2 2 chunks +57 lines, -14 lines 0 comments Download
M site/user/quick/android.md View 1 2 3 1 chunk +3 lines, -1 line 0 comments Download
M third_party/yasm/README.skia View 1 chunk +0 lines, -4 lines 0 comments Download
D third_party/yasm/config/android/yasm View Binary file 0 comments Download

Depends on Patchset:

Messages

Total messages: 20 (9 generated)
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1239333002/40001
5 years, 5 months ago (2015-07-20 20:21:20 UTC) #4
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
5 years, 5 months ago (2015-07-20 20:29:42 UTC) #6
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1239333002/60001
5 years, 5 months ago (2015-07-21 17:24:00 UTC) #8
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
5 years, 5 months ago (2015-07-21 17:31:10 UTC) #10
msarett
5 years, 5 months ago (2015-07-21 17:53:10 UTC) #12
djsollen
I'm fine if the mac doesn't get the best version of libjpeg-turbo, but still want ...
5 years, 5 months ago (2015-07-21 18:14:01 UTC) #13
djsollen
lgtm
5 years, 5 months ago (2015-07-21 18:14:14 UTC) #14
msarett
Cool good to know! I'll add a comment to setup_toolchain.sh. Do you think it also ...
5 years, 5 months ago (2015-07-21 18:24:36 UTC) #15
djsollen
yes, please put it in the android quickstart portion of our documentation.
5 years, 5 months ago (2015-07-21 18:28:15 UTC) #16
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1239333002/100001
5 years, 5 months ago (2015-07-21 18:49:02 UTC) #19
commit-bot: I haz the power
5 years, 5 months ago (2015-07-21 19:01:51 UTC) #20
Message was sent while issue was closed.
Committed patchset #4 (id:100001) as
https://skia.googlesource.com/skia/+/cf2a6a47e4db5682798fe46f9e3ef14a27ff4b2b

Powered by Google App Engine
This is Rietveld 408576698