Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(135)

Unified Diff: third_party/yasm/README.skia

Issue 1239333002: Reenable yasm for Android x86 and x86-64 on Linux (Closed) Base URL: https://skia.googlesource.com/skia.git@master
Patch Set: Adding documentation Created 5 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « site/user/quick/android.md ('k') | third_party/yasm/config/android/yasm » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: third_party/yasm/README.skia
diff --git a/third_party/yasm/README.skia b/third_party/yasm/README.skia
index 19a259ccf149cc4bdfc7e2f60bece816b6bf96cc..94bdd785d74cffd83b64c0aeb6428559ea8387c7 100644
--- a/third_party/yasm/README.skia
+++ b/third_party/yasm/README.skia
@@ -8,10 +8,6 @@ the yasm code is pulled into externals via the DEPS file.
Chromium builds yasm using the below procedure. We take a few shortcuts. We mirror Chromium's
yasm repositories in our DEPS file, and we copy these config files directly from Chromium.
-NOTE: We were are currently unable to build yasm for Android on x86 and x86_64. Instead we are
-using a precompiled binary in the config/android directory.
-TODO (msarett): Fix this!
-
Excerpt from [chromium] //src/third_party/yasm/README.chromium:
Instructions for recreating the yasm.gyp file.
« no previous file with comments | « site/user/quick/android.md ('k') | third_party/yasm/config/android/yasm » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698