Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(585)

Issue 1238993002: Revert of Make the static clang/win ToT bots do official builds. (Closed)

Created:
5 years, 5 months ago by Nico
Modified:
5 years, 5 months ago
CC:
chromium-reviews, kjellander-cc_chromium.org, stip+watch_chromium.org
Target Ref:
refs/remotes/origin/master
Project:
build
Visibility:
Public.

Description

Revert of Make the static clang/win ToT bots do official builds. (patchset #1 id:1 of https://codereview.chromium.org/1241913003/) Reason for revert: Looks like the bot doesn't have a src-internal checkout and this isn't enough to give it one. Reverting until src-internalness is figured out. Original issue's description: > Make the static clang/win ToT bots do official builds. > > That makes them match the regular win/clang bots. > > (It means we lose waterfall coverage for unofficial static library builds, > but coverage from unofficial component builders hopefully gives us most of > that.) > > BUG=82385 > TBR=akuegel > > Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=296026 TBR=hans@chromium.org,rnk@chromium.org,akuegel@chromium.org NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=82385 Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=296028

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -14 lines) Patch
M scripts/slave/recipe_modules/chromium/config.py View 1 chunk +0 lines, -4 lines 0 comments Download
M scripts/slave/recipe_modules/chromium_tests/chromium_fyi.py View 2 chunks +2 lines, -2 lines 0 comments Download
M scripts/slave/recipes/chromium.expected/full_chromium_fyi_ClangToTWin.json View 2 chunks +1 line, -4 lines 0 comments Download
M scripts/slave/recipes/chromium.expected/full_chromium_fyi_ClangToTWin64.json View 2 chunks +1 line, -4 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
Nico
Created Revert of Make the static clang/win ToT bots do official builds.
5 years, 5 months ago (2015-07-15 20:51:43 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1238993002/1
5 years, 5 months ago (2015-07-15 20:52:02 UTC) #2
commit-bot: I haz the power
Committed patchset #1 (id:1) as http://src.chromium.org/viewvc/chrome?view=rev&revision=296028
5 years, 5 months ago (2015-07-15 20:52:13 UTC) #3
hans
I think you need something like this: https://codereview.chromium.org/1004523002/
5 years, 5 months ago (2015-07-15 21:04:26 UTC) #4
Adrian Kuegel
5 years, 5 months ago (2015-07-16 07:45:36 UTC) #5
Message was sent while issue was closed.
lgtm

Powered by Google App Engine
This is Rietveld 408576698