chromium_win_clang_official recipe config: check out internal sources

chromium_win_clang_official recipe config: check out internal sources

BUG=451078
NOPRESUBMIT=true

Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=294411

[hans, 2015-03-11 21:55:04]

hans@chromium.org changed reviewers:
+ iannucci@chromium.org, rnk@chromium.org

[hans, 2015-03-11 21:55:05]

Turns out it doesn't automagically check out the internal sources :)

[Reid Kleckner, 2015-03-11 22:11:23]

rslgtm, but Robert will have to stamp for OWNERS anyway.

[iannucci, 2015-03-11 22:47:14]

rs-lgtm, though please look at the expectation JSONs :D. They're not lying to
you, it'll do exactly what they say (% data pulled from the chromium/src
checkout like lists of tests).

You can also run it locally with the 'run_recipe' tool. Check the 'run_recipe'
link at the top of your broken build (picking a random builder:
http://build.chromium.org/p/chromium.win/builders/XP%20Tests%20%281%29/builds...),
and follow the instructions. This will execute the entire build on your machine.
If you modify the recipes (as in this CL), you should be able to see that it
works as intended :)

[hans, 2015-03-11 22:58:49]

On 2015/03/11 22:47:14, iannucci wrote:
> rs-lgtm, though please look at the expectation JSONs :D. They're not lying to
> you, it'll do exactly what they say (% data pulled from the chromium/src
> checkout like lists of tests).

I do look at them, but with the last patch I didn't make the observation that
there were things missing (I don't work with the internal sources a lot).


> You can also run it locally with the 'run_recipe' tool. Check the 'run_recipe'
> link at the top of your broken build (picking a random builder:
>
http://build.chromium.org/p/chromium.win/builders/XP%20Tests%20%281%29/builds...),
> and follow the instructions. This will execute the entire build on your
machine.
> If you modify the recipes (as in this CL), you should be able to see that it
> works as intended :)

Thanks! That seems useful.

[hans, 2015-03-11 22:58:52]

The CQ bit was checked by hans@chromium.org

[commit-bot: I haz the power, 2015-03-11 22:59:13]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1004523002/1

[commit-bot: I haz the power, 2015-03-11 23:01:10]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-03-11 23:01:11]

Presubmit check for 1004523002-1 failed and returned exit status 1.

Running presubmit commit checks ...

** Presubmit ERRORS **
tests/masters_test.py (0.81s) failed
ERROR:root:Found unexpected master V8 Branches on port 8046


Presubmit checks took 112.5s to calculate.

[hans, 2015-03-11 23:01:50]

The CQ bit was checked by hans@chromium.org

[commit-bot: I haz the power, 2015-03-11 23:02:04]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1004523002/1

[commit-bot: I haz the power, 2015-03-11 23:02:24]

Committed patchset #1 (id:1) as
http://src.chromium.org/viewvc/chrome?view=rev&revision=294411