Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(70)

Issue 1241913003: Make the static clang/win ToT bots do official builds. (Closed)

Created:
5 years, 5 months ago by Nico
Modified:
5 years, 5 months ago
CC:
chromium-reviews, kjellander-cc_chromium.org, stip+watch_chromium.org
Target Ref:
refs/heads/master
Project:
build
Visibility:
Public.

Description

Make the static clang/win ToT bots do official builds. That makes them match the regular win/clang bots. (It means we lose waterfall coverage for unofficial static library builds, but coverage from unofficial component builders hopefully gives us most of that.) BUG=82385 TBR=akuegel Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=296036

Patch Set 1 #

Patch Set 2 : also check out src-internal #

Unified diffs Side-by-side diffs Delta from patch set Stats (+18 lines, -6 lines) Patch
M scripts/slave/recipe_modules/chromium/config.py View 1 chunk +4 lines, -0 lines 0 comments Download
M scripts/slave/recipe_modules/chromium_tests/chromium_fyi.py View 1 2 chunks +4 lines, -2 lines 0 comments Download
M scripts/slave/recipes/chromium.expected/full_chromium_fyi_ClangToTWin.json View 1 3 chunks +5 lines, -2 lines 0 comments Download
M scripts/slave/recipes/chromium.expected/full_chromium_fyi_ClangToTWin64.json View 1 3 chunks +5 lines, -2 lines 0 comments Download

Messages

Total messages: 24 (9 generated)
Nico
5 years, 5 months ago (2015-07-15 18:27:00 UTC) #2
hans
lgtm Was there any particular motivation besides wanting more official build coverage?
5 years, 5 months ago (2015-07-15 18:30:55 UTC) #3
Nico
Yeah, today's clang/win roll broke tests on the official pinned bots (the same tests that ...
5 years, 5 months ago (2015-07-15 18:32:10 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1241913003/1
5 years, 5 months ago (2015-07-15 18:38:37 UTC) #6
commit-bot: I haz the power
Try jobs failed on following builders: build_presubmit on tryserver.chromium.linux (JOB_FAILED, no build URL)
5 years, 5 months ago (2015-07-15 19:40:02 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1241913003/1
5 years, 5 months ago (2015-07-15 19:42:04 UTC) #10
commit-bot: I haz the power
Try jobs failed on following builders: build_presubmit on tryserver.chromium.linux (JOB_FAILED, no build URL)
5 years, 5 months ago (2015-07-15 19:53:10 UTC) #12
Nico
+akuegel tbr
5 years, 5 months ago (2015-07-15 20:08:44 UTC) #14
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1241913003/1
5 years, 5 months ago (2015-07-15 20:09:06 UTC) #16
commit-bot: I haz the power
Committed patchset #1 (id:1) as http://src.chromium.org/viewvc/chrome?view=rev&revision=296026
5 years, 5 months ago (2015-07-15 20:12:13 UTC) #17
Nico
A revert of this CL (patchset #1 id:1) has been created in https://codereview.chromium.org/1238993002/ by thakis@chromium.org. ...
5 years, 5 months ago (2015-07-15 20:51:43 UTC) #18
Nico
trying this again in patch set 2
5 years, 5 months ago (2015-07-16 02:29:25 UTC) #19
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1241913003/20001
5 years, 5 months ago (2015-07-16 02:29:44 UTC) #22
commit-bot: I haz the power
Committed patchset #2 (id:20001) as http://src.chromium.org/viewvc/chrome?view=rev&revision=296036
5 years, 5 months ago (2015-07-16 02:32:31 UTC) #23
Adrian Kuegel
5 years, 5 months ago (2015-07-16 07:44:31 UTC) #24
Message was sent while issue was closed.
lgtm

Powered by Google App Engine
This is Rietveld 408576698