Issue 1238983002: Initial ui/gl updates for Mac Sky shell target

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 1238983002: Initial ui/gl updates for Mac Sky shell target (Closed)

Created:
5 years, 5 months ago by Chinmay

Modified:
5 years, 5 months ago

Reviewers:
abarth-chromium, eseidel

CC:
mojo-reviews_chromium.org

Base URL:
https://github.com/domokit/mojo.git@master

Target Ref:
refs/heads/master

Project:
mojo

Visibility:
Public.

Created: 5 years, 5 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+562 lines, -95 lines)			Patch
M	ui/gfx/native_widget_types.h	View	1 chunk	+3 lines, -0 lines	0 comments	Download
M	ui/gl/BUILD.gn	View	4 chunks	+13 lines, -1 line	0 comments	Download
A +	ui/gl/gl_context_cgl.h	View	2 chunks	+20 lines, -17 lines	0 comments	Download
A	ui/gl/gl_context_cgl.cc	View	1 chunk	+304 lines, -0 lines	0 comments	Download
A +	ui/gl/gl_context_mac.mm	View	2 chunks	+12 lines, -26 lines	0 comments	Download
A +	ui/gl/gl_implementation_mac.cc	View	4 chunks	+50 lines, -51 lines	0 comments	Download
A	ui/gl/gl_surface_mac.cc	View	1 chunk	+160 lines, -0 lines	0 comments	Download

Total messages: 4 (1 generated)

Chinmay

This mostly just imports the missing files from Chromium. Some had to be updated due ...

5 years, 5 months ago (2015-07-15 20:42:03 UTC) #2

Chinmay

5 years, 5 months ago (2015-07-15 21:10:52 UTC) #4

Message was sent while issue was closed.

Committed patchset #1 (id:1) manually as
aaeb3152be26163756c6e29df9f656458b119d99 (presubmit successful).