Require manifests for native messaging hosts.

Require manifests for native messaging hosts.

Previously native messaging hosts were discovered by looking in the user 
data directory. That approach is hard to use and is not reliable. Now 
chrome will look for a host manifest file in a system-specific directory 
and load that file to find host binary.

This is a second attempt to land this CL as it was reverted (see 
https://codereview.chromium.org/12386018). The problem that caused it to
be reverted was not related to this CL.

BUG=142915
TBR=mpcomplete@chromium.org

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=185382

[Sergey Ulanov, 2013-03-01 00:16:48]

Committed patchset #1 manually as r185382 (presubmit successful).

[Matt Perry, 2013-03-01 00:17:20]

rubber-stamp LGTM

[Nico, 2013-03-20 04:04:27]

https://codereview.chromium.org/12389041/diff/1/chrome/browser/extensions/api...
File chrome/browser/extensions/api/messaging/native_process_launcher_posix.cc
(right):

https://codereview.chromium.org/12389041/diff/1/chrome/browser/extensions/api...
chrome/browser/extensions/api/messaging/native_process_launcher_posix.cc:19: #if
defined(OS_MAXOSX)
OS_MAXOSX should be OS_MACOSX (note C instead of X). I'm fixing this in
https://codereview.chromium.org/12566038 ; shout if that's wrong.

(…but: /Library/Chrome is almost certainly the wrong place for anything. We do
keep some chrome stuff in /Library/Google, but only admins can write to that.
Normally you'd put stuff in a subdir of chrome::GetDefaultUserDataDirectory(),
which expands to ~/Library/Application Support/(Google/Chrome|Chromium). Please
take a look at changing this directory.)

[Sergey Ulanov, 2013-03-20 04:25:15]

https://codereview.chromium.org/12389041/diff/1/chrome/browser/extensions/api...
File chrome/browser/extensions/api/messaging/native_process_launcher_posix.cc
(right):

https://codereview.chromium.org/12389041/diff/1/chrome/browser/extensions/api...
chrome/browser/extensions/api/messaging/native_process_launcher_posix.cc:19: #if
defined(OS_MAXOSX)
On 2013/03/20 04:04:27, Nico wrote:
> OS_MAXOSX should be OS_MACOSX (note C instead of X). I'm fixing this in
> https://codereview.chromium.org/12566038 ; shout if that's wrong.

Thanks for catching and fixing it!

> 
> (…but: /Library/Chrome is almost certainly the wrong place for anything. We do
> keep some chrome stuff in /Library/Google, but only admins can write to that.

We actually do want this directory to be writable by admin only. Do you think I
should change this path to /Library/Google/Chrome/NativeMessagingHosts ?

> Normally you'd put stuff in a subdir of chrome::GetDefaultUserDataDirectory(),
> which expands to ~/Library/Application Support/(Google/Chrome|Chromium).
Please
> take a look at changing this directory.)

This directory contains native messaging hosts that are installed per-system and
installation should require admin permissions. User data directory is a wrong
place for it.

[Nico, 2013-03-20 04:42:50]

https://codereview.chromium.org/12389041/diff/1/chrome/browser/extensions/api...
File chrome/browser/extensions/api/messaging/native_process_launcher_posix.cc
(right):

https://codereview.chromium.org/12389041/diff/1/chrome/browser/extensions/api...
chrome/browser/extensions/api/messaging/native_process_launcher_posix.cc:19: #if
defined(OS_MAXOSX)
On 2013/03/20 04:25:15, sergeyu wrote:
> On 2013/03/20 04:04:27, Nico wrote:
> > OS_MAXOSX should be OS_MACOSX (note C instead of X). I'm fixing this in
> > https://codereview.chromium.org/12566038 ; shout if that's wrong.
> 
> Thanks for catching and fixing it!
> 
> > 
> > (…but: /Library/Chrome is almost certainly the wrong place for anything. We
do
> > keep some chrome stuff in /Library/Google, but only admins can write to
that.
> 
> We actually do want this directory to be writable by admin only. Do you think
I
> should change this path to /Library/Google/Chrome/NativeMessagingHosts ?

Sounds good. The master prefs file is right in /Library/Google, but other stuff
seems to be scoped by product, so /Library/Google/Chrome is probably good. Not
sure if unbranded builds should use /Library/Chromium instead.

Let mark@chromium.org review your CL, he'll probably have an opinion on this.

> 
> > Normally you'd put stuff in a subdir of
chrome::GetDefaultUserDataDirectory(),
> > which expands to ~/Library/Application Support/(Google/Chrome|Chromium).
> Please
> > take a look at changing this directory.)
> 
> This directory contains native messaging hosts that are installed per-system
and
> installation should require admin permissions. User data directory is a wrong
> place for it. 
>