Require manifests for native messaging hosts.

chrome/browser/extensions/api/messaging/native_process_launcher_posix.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/extensions/api/messaging/native_process_launcher.h"
 
 #include "base/command_line.h"
 #include "base/file_util.h"
 #include "base/logging.h"
 #include "base/posix/eintr_wrapper.h"
 #include "base/process_util.h"
+#include "chrome/browser/extensions/api/messaging/native_messaging_host_manifest.h"
 
 namespace extensions {
 
+namespace {
+
+const char kNativeMessagingDirectory[] =
+#if defined(OS_MAXOSX)

[Nico, 2013/03/20 04:04:27]

OS_MAXOSX should be OS_MACOSX (note C instead of X). I'm fixing this in
https://codereview.chromium.org/12566038 ; shout if that's wrong.

(…but: /Library/Chrome is almost certainly the wrong place for anything. We do
keep some chrome stuff in /Library/Google, but only admins can write to that.
Normally you'd put stuff in a subdir of chrome::GetDefaultUserDataDirectory(),
which expands to ~/Library/Application Support/(Google/Chrome|Chromium). Please
take a look at changing this directory.)

[Sergey Ulanov, 2013/03/20 04:25:15]

Thanks for catching and fixing it!
We actually do want this directory to be writable by admin only. Do you think I
should change this path to /Library/Google/Chrome/NativeMessagingHosts ?
This directory contains native messaging hosts that are installed per-system and
installation should require admin permissions. User data directory is a wrong
place for it. 

[Nico, 2013/03/20 04:42:51]

Sounds good. The master prefs file is right in /Library/Google, but other stuff
seems to be scoped by product, so /Library/Google/Chrome is probably good. Not
sure if unbranded builds should use /Library/Chromium instead.

Let mark@chromium.org review your CL, he'll probably have an opinion on this.

+    "/Library/Chrome/NativeMessagingHosts";
+#else
+    "/etc/opt/chrome/native-messaging-hosts";
+#endif
+
+}  // namespace
+
+// static
+scoped_ptr<NativeMessagingHostManifest>
+NativeProcessLauncher::FindAndLoadManifest(
+    const std::string& native_host_name,
+    std::string* error_message) {
+  base::FilePath manifest_path =
+      base::FilePath(kNativeMessagingDirectory).Append(
+          native_host_name + ".json");
+  return NativeMessagingHostManifest::Load(manifest_path, error_message);
+}
+
 // static
 bool NativeProcessLauncher::LaunchNativeProcess(
     const base::FilePath& path,
     base::PlatformFile* read_file,
     base::PlatformFile* write_file) {
   base::FileHandleMappingVector fd_map;
 
   int read_pipe_fds[2] = {0};
   if (HANDLE_EINTR(pipe(read_pipe_fds)) != 0) {
     LOG(ERROR) << "Bad read pipe";
@@ skipping 25 matching lines @@
   write_pipe_read_fd.reset();
   read_pipe_write_fd.reset();
 
   *read_file = *read_pipe_read_fd.release();
   *write_file = *write_pipe_write_fd.release();
 
   return true;
 }
 
 }  // namespace extensions