Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(209)

Issue 12386018: Revert 185189. (Closed)

Created:
7 years, 9 months ago by tommi (sloooow) - chröme
Modified:
7 years, 9 months ago
Reviewers:
Sergey Ulanov
CC:
chromium-reviews, Aaron Boodman, sail+watch_chromium.org, chromium-apps-reviews_chromium.org
Visibility:
Public.

Description

Revert 185189. This caused the NativeMessageBasic to timeout on cros and precise bots. Example output: ExtensionApiTest.NativeMessageBasic: [27122:27146:0228/021309:2707841027:ERROR:nss_util.cc(492)] Error initializing NSS with a persistent database (sql:/etc/fake_root_ca/nssdb): NSS error code: -8174 Xlib: extension "GLX" missing on display ":9.0". [27122:27122:0228/021309:2707849603:ERROR:gl_surface_glx.cc(326)] glxQueryVersion failed [27122:27122:0228/021309:2707849652:ERROR:gl_surface_linux.cc(58)] GLSurfaceGLX::InitializeOneOff failed. [27122:27122:0228/021309:2707849685:ERROR:compositor.cc(140)] Could not load the GL bindings Xlib: extension "RANDR" missing on display ":9.0". Xlib: extension "GLX" missing on display ":9.0". [27153:27153:0228/021310:ERROR:gl_surface_glx.cc(326)] glxQueryVersion failed [27153:27153:0228/021310:ERROR:gl_surface_linux.cc(58)] GLSurfaceGLX::InitializeOneOff failed. [27153:27153:0228/021310:ERROR:nss_util.cc(492)] Error initializing NSS with a persistent database (sql:/etc/fake_root_ca/nssdb): NSS error code: -8174 Xlib: extension "GLX" missing on display ":9.0". [27171:27171:0228/021310:ERROR:gl_surface_glx.cc(326)] glxQueryVersion failed [27171:27171:0228/021310:ERROR:gl_surface_linux.cc(58)] GLSurfaceGLX::InitializeOneOff failed. [27171:27171:0228/021310:ERROR:nss_util.cc(492)] Error initializing NSS with a persistent database (sql:/etc/fake_root_ca/nssdb): NSS error code: -8174 [27122:27155:0228/021310:2708725028:ERROR:native_process_launcher.cc(94)] Could not find native host: com.google.chrome.test.echo [27122:27155:0228/021310:2708736310:ERROR:native_process_launcher.cc(94)] Could not find native host: com.google.chrome.test.echo [27122:27155:0228/021310:2708739432:ERROR:native_process_launcher.cc(94)] Could not find native host: com.google.chrome.test.echo Killed (timed out). > Require manifests for native messaging hosts. > > Previously native messaging hosts were discovered by looking in the user > data directory. That approach is hard to use and is not reliable. Now > chrome will look for a host manifest file in a system-specific directory > and load that file to find host binary. > > BUG=142915 > TBR=thakis@chromium.org > > Review URL: https://chromiumcodereview.appspot.com/12285015 TBR=sergeyu@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=185207

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+46 lines, -580 lines) Patch
M chrome/browser/extensions/api/messaging/message_service.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/extensions/api/messaging/native_message_process_host.h View 4 chunks +2 lines, -7 lines 0 comments Download
M chrome/browser/extensions/api/messaging/native_message_process_host.cc View 6 chunks +6 lines, -15 lines 0 comments Download
M chrome/browser/extensions/api/messaging/native_message_process_host_unittest.cc View 5 chunks +4 lines, -6 lines 0 comments Download
M chrome/browser/extensions/api/messaging/native_messaging_apitest.cc View 1 chunk +7 lines, -46 lines 0 comments Download
D chrome/browser/extensions/api/messaging/native_messaging_host_manifest.h View 1 chunk +0 lines, -62 lines 0 comments Download
D chrome/browser/extensions/api/messaging/native_messaging_host_manifest.cc View 1 chunk +0 lines, -138 lines 0 comments Download
D chrome/browser/extensions/api/messaging/native_messaging_host_manifest_unittest.cc View 1 chunk +0 lines, -127 lines 0 comments Download
M chrome/browser/extensions/api/messaging/native_process_launcher.h View 2 chunks +5 lines, -21 lines 0 comments Download
M chrome/browser/extensions/api/messaging/native_process_launcher.cc View 6 chunks +18 lines, -76 lines 0 comments Download
M chrome/browser/extensions/api/messaging/native_process_launcher_posix.cc View 1 chunk +0 lines, -23 lines 0 comments Download
M chrome/browser/extensions/api/messaging/native_process_launcher_win.cc View 1 chunk +0 lines, -45 lines 0 comments Download
M chrome/chrome_browser_extensions.gypi View 1 chunk +0 lines, -2 lines 0 comments Download
M chrome/chrome_tests_unit.gypi View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/common/chrome_switches.h View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/common/chrome_switches.cc View 1 chunk +0 lines, -5 lines 0 comments Download
M chrome/common/extensions/docs/examples/extensions/native_messaging/popup.js View 1 chunk +2 lines, -1 line 0 comments Download
M chrome/test/data/extensions/api_test/native_messaging/manifest.json View 1 chunk +0 lines, -2 lines 0 comments Download
M chrome/test/data/extensions/api_test/native_messaging/test.js View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 5 (0 generated)
tommi (sloooow) - chröme
7 years, 9 months ago (2013-02-28 10:39:33 UTC) #1
tommi (sloooow) - chröme
Committed patchset #1 manually as r185207.
7 years, 9 months ago (2013-02-28 10:39:52 UTC) #2
Sergey Ulanov
This is clearly not caused by my CL - instead it seems to be a ...
7 years, 9 months ago (2013-03-01 00:12:55 UTC) #3
tommi (sloooow) - chröme
OK, thanks. I didn't go in and debug the issue. There was a correlation between ...
7 years, 9 months ago (2013-03-01 07:52:59 UTC) #4
Sergey Ulanov
7 years, 9 months ago (2013-03-02 03:18:31 UTC) #5
On Thu, Feb 28, 2013 at 11:52 PM, Tommi <tommi@chromium.org> wrote:

> OK, thanks.  I didn't go in and debug the issue.  There was a correlation
> between your cl and the failing test so I tried revert and the test started
> passing.  Good luck with relanding and thanks for understanding.
>

I wasn't complaining. I would revert it in these circumstances too :-)



>
>
> On Fri, Mar 1, 2013 at 1:12 AM, <sergeyu@chromium.org> wrote:
>
>> This is clearly not caused by my CL - instead it seems to be a bug in the
>> tests
>> infrastructure. The error message "Could not find native host..." was
>> removed in
>> my CL, so it looks like the problem is that the bot was running old test
>> binary
>> with newer test files, I'm not sure how that could happen. Going to try
>> relanding it.
>>
>>
https://codereview.chromium.**org/12386018/<https://codereview.chromium.org/1...
>>
>
>

Powered by Google App Engine
This is Rietveld 408576698