Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1355)

Unified Diff: Source/platform/fonts/FontPlatformData.cpp

Issue 1238753005: Add unit tests for FontPlatformData::hasSpaceInLigaturesOrKerning (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master
Patch Set: Created 5 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: Source/platform/fonts/FontPlatformData.cpp
diff --git a/Source/platform/fonts/FontPlatformData.cpp b/Source/platform/fonts/FontPlatformData.cpp
index 45bf8089543b9e662c2eb2af53860ee3b05aeea9..7876786ce159a2cd1fdfbee0de914a844818c767 100644
--- a/Source/platform/fonts/FontPlatformData.cpp
+++ b/Source/platform/fonts/FontPlatformData.cpp
@@ -289,7 +289,7 @@ bool FontPlatformData::hasSpaceInLigaturesOrKerning(
{
const HarfBuzzFace* hbFace = harfBuzzFace();
if (!hbFace)
- return true;
+ return false;
leviw_travelin_and_unemployed 2015/07/16 00:01:39 This makes way more sense.
hb_face_t* face = hbFace->face();
ASSERT(face);
@@ -301,11 +301,11 @@ bool FontPlatformData::hasSpaceInLigaturesOrKerning(
// will be rendering using a fallback font, which grantees that it cannot
// affect the shape of the preceding word.
if (!hb_font_get_glyph(font, spaceCharacter, 0, &space))
- return true;
+ return false;
if (!hb_ot_layout_has_substitution(face)
&& !hb_ot_layout_has_positioning(face)) {
- return true;
+ return false;
}
bool foundSpaceInTable = false;

Powered by Google App Engine
This is Rietveld 408576698