Source/platform/blink_platform.gypi - Issue 1238753005: Add unit tests for FontPlatformData::hasSpaceInLigaturesOrKerning

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/platform/blink_platform.gypi

Issue 1238753005: Add unit tests for FontPlatformData::hasSpaceInLigaturesOrKerning (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: Created 5 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: Source/platform/blink_platform.gypi

diff --git a/Source/platform/blink_platform.gypi b/Source/platform/blink_platform.gypi

index be2940e8301ecb1d14182630d34a7622d2e69cc8..53632769d04641730f0ee1d771448e65dbee5195 100644

--- a/Source/platform/blink_platform.gypi

+++ b/Source/platform/blink_platform.gypi

@@ -1002,8 +1002,12 @@

'weborigin/SecurityOriginTest.cpp',

'weborigin/SecurityPolicyTest.cpp',

- # NOTE: these are legacy unit tests, do not add more!

+ # NOTE: These are legacy unit tests and tests that require a Platform

leviw_travelin_and_unemployed 2015/07/16 00:01:39 This comment is a little confusing to me.

eae 2015/07/16 00:21:54 will reword, thanks.

+ # object and are a part of the web:webkit_unit_tests binary.

+ # Do not add more unless the test requires a Platform object.

'platform_web_unittest_files': [

+ 'fonts/FontPlatformDataTest.cpp',

+ 'fonts/TestFontSelector.h',

'graphics/BitmapImageTest.cpp',

'graphics/Canvas2DLayerBridgeTest.cpp',

'graphics/Canvas2DLayerManagerTest.cpp',

« no previous file with comments | « no previous file | Source/platform/fonts/FontPlatformData.cpp » ('j') | Source/platform/fonts/FontPlatformData.cpp » ('J')