Add unit tests for FontPlatformData::hasSpaceInLigaturesOrKerning

Source/platform/fonts/FontPlatformData.cpp

 /*
  * Copyright (C) 2011 Brent Fulgham
  *
  * This library is free software; you can redistribute it and/or
  * modify it under the terms of the GNU Library General Public
  * License as published by the Free Software Foundation; either
  * version 2 of the License, or (at your option) any later version.
  *
  * This library is distributed in the hope that it will be useful,
  * but WITHOUT ANY WARRANTY; without even the implied warranty of
@@ skipping 271 matching lines @@
             return true;
     }
     return false;
 }
 
 bool FontPlatformData::hasSpaceInLigaturesOrKerning(
     TypesettingFeatures features) const
 {
     const HarfBuzzFace* hbFace = harfBuzzFace();
     if (!hbFace)
-        return true;
+        return false;

[leviw_travelin_and_unemployed, 2015/07/16 00:01:39]

This makes way more sense.

 
     hb_face_t* face = hbFace->face();
     ASSERT(face);
     hb_font_t* font = hbFace->createFont();
     ASSERT(font);
 
     hb_codepoint_t space;
     // If the space glyph isn't present in the font then each space character
     // will be rendering using a fallback font, which grantees that it cannot
     // affect the shape of the preceding word.
     if (!hb_font_get_glyph(font, spaceCharacter, 0, &space))
-        return true;
+        return false;
 
     if (!hb_ot_layout_has_substitution(face)
         && !hb_ot_layout_has_positioning(face)) {
-        return true;
+        return false;
     }
 
     bool foundSpaceInTable = false;
     hb_set_t* glyphs = hb_set_create();
     if (features & Kerning)
         foundSpaceInTable = tableHasSpace(face, glyphs, HB_OT_TAG_GPOS, space);
     if (!foundSpaceInTable && (features & Ligatures))
         foundSpaceInTable = tableHasSpace(face, glyphs, HB_OT_TAG_GSUB, space);
 
     hb_set_destroy(glyphs);
@@ skipping 44 matching lines @@
     const size_t tableSize = m_typeface->getTableSize(tag);
     if (tableSize) {
         Vector<char> tableBuffer(tableSize);
         m_typeface->getTableData(tag, 0, tableSize, &tableBuffer[0]);
         buffer = SharedBuffer::adoptVector(tableBuffer);
     }
     return buffer.release();
 }
 
 } // namespace blink