Unwind PDFObject destructor calls into heap instead of stack. Notice: the order of the destructors …

Unwind PDFObject destructor calls into heap instead of stack. Notice: the order of the destructors called is not preserved, but by using refcounting we were not in control anyway. This change does not unwind all classes that inherit PDFObject, but only the ones that we absolutely must in order to avoid stack overflow during normal executions. If the issue appears again we can make this change in other classes too.

[edisonn, 2013-03-05 18:38:39]

On 2013/03/04 15:44:27, edisonn wrote:

ping

[vandebo (ex-Chrome), 2013-03-05 18:50:38]

On 2013/03/05 18:38:39, edisonn wrote:
> On 2013/03/04 15:44:27, edisonn wrote:
> 
> ping

Sorry, I've been pretty buried lately. But I'm also pretty skeptical of the need
for this.  What are your repro steps for the problem?

[reed1, 2013-03-05 18:51:21]

https://codereview.chromium.org/12387086/diff/5002/include/core/SkRefCnt.h
File include/core/SkRefCnt.h (right):

https://codereview.chromium.org/12387086/diff/5002/include/core/SkRefCnt.h#ne...
include/core/SkRefCnt.h:110: friend class SkPDFObject;
ick. If we must do this, please ad a detailed comment here explaining why.

[Tom Hudson, 2013-03-07 13:54:37]

https://codereview.chromium.org/12387086/diff/15001/src/pdf/SkPDFGraphicState.h
File src/pdf/SkPDFGraphicState.h (right):

https://codereview.chromium.org/12387086/diff/15001/src/pdf/SkPDFGraphicState...
src/pdf/SkPDFGraphicState.h:68: virtual void
trasferPDFObjecsOwnership(SkTDArray<SkPDFObject*>* list) {
Spelling errors: transfer, Objects

https://codereview.chromium.org/12387086/diff/15001/src/pdf/SkPDFTypes.h
File src/pdf/SkPDFTypes.h (right):

https://codereview.chromium.org/12387086/diff/15001/src/pdf/SkPDFTypes.h#newc...
src/pdf/SkPDFTypes.h:84: /** Destroys safely an array of SkPDFObject's.
nit: no apostrophe

https://codereview.chromium.org/12387086/diff/15001/src/pdf/SkPDFTypes.h#newc...
src/pdf/SkPDFTypes.h:86: *  @param list: The list of objects to be destroyed.
nit: redundant @param

https://codereview.chromium.org/12387086/diff/15001/src/pdf/SkPDFTypes.h#newc...
src/pdf/SkPDFTypes.h:118: *  @param list: The list that will own the SkPDFObject
members.
This @param declaration doesn't actually explain what's going on (perhaps
because of verb tense?), but we don't normally require @param for everything,
and it is adequately covered by the function comment.

[edisonn, 2013-03-07 16:51:30]

https://codereview.chromium.org/12387086/diff/15001/src/pdf/SkPDFGraphicState.h
File src/pdf/SkPDFGraphicState.h (right):

https://codereview.chromium.org/12387086/diff/15001/src/pdf/SkPDFGraphicState...
src/pdf/SkPDFGraphicState.h:68: virtual void
trasferPDFObjecsOwnership(SkTDArray<SkPDFObject*>* list) {
On 2013/03/07 13:54:37, Tom Hudson wrote:
> Spelling errors: transfer, Objects

Done.

https://codereview.chromium.org/12387086/diff/15001/src/pdf/SkPDFTypes.h
File src/pdf/SkPDFTypes.h (right):

https://codereview.chromium.org/12387086/diff/15001/src/pdf/SkPDFTypes.h#newc...
src/pdf/SkPDFTypes.h:84: /** Destroys safely an array of SkPDFObject's.
On 2013/03/07 13:54:37, Tom Hudson wrote:
> nit: no apostrophe

Done.

https://codereview.chromium.org/12387086/diff/15001/src/pdf/SkPDFTypes.h#newc...
src/pdf/SkPDFTypes.h:86: *  @param list: The list of objects to be destroyed.
On 2013/03/07 13:54:37, Tom Hudson wrote:
> nit: redundant @param
removed

https://codereview.chromium.org/12387086/diff/15001/src/pdf/SkPDFTypes.h#newc...
src/pdf/SkPDFTypes.h:118: *  @param list: The list that will own the SkPDFObject
members.
On 2013/03/07 13:54:37, Tom Hudson wrote:
> This @param declaration doesn't actually explain what's going on (perhaps
> because of verb tense?), but we don't normally require @param for everything,
> and it is adequately covered by the function comment.

Done.