Unwind PDFObject destructor calls into heap instead of stack. Notice: the order of the destructors …

include/core/SkRefCnt.h

 
 /*
  * Copyright 2006 The Android Open Source Project
  *
  * Use of this source code is governed by a BSD-style license that can be
  * found in the LICENSE file.
  */
 
 
 #ifndef SkRefCnt_DEFINED
@@ skipping 89 matching lines @@
      *  Called when the ref count goes to 0.
      */
     virtual void internal_dispose() const {
         this->internal_dispose_restore_refcnt_to_1();
         SkDELETE(this);
     }
 
     friend class SkWeakRefCnt;
     friend class GrTexture;     // to allow GrTexture's internal_dispose to
                                 // call SkRefCnt's & directly set fRefCnt (to 1)
+    friend class SkPDFObject;

[reed1, 2013/03/05 18:51:21]

ick. If we must do this, please ad a detailed comment here explaining why.

 
     mutable int32_t fRefCnt;
 
     typedef SkNoncopyable INHERITED;
 };
 
 ///////////////////////////////////////////////////////////////////////////////
 
 /** Helper macro to safely assign one SkRefCnt[TS]* to another, checking for
     null in on each side of the assignment, and ensuring that ref() is called
@@ skipping 135 matching lines @@
     typedef T* SkRefPtr::*unspecified_bool_type;
     operator unspecified_bool_type() const {
         return fObj ? &SkRefPtr::fObj : NULL;
     }
 
 private:
     T* fObj;
 };
 
 #endif