src/pdf/SkPDFDevice.cpp - Issue 12387086: Unwind PDFObject destructor calls into heap instead of stack. Notice: the order of the destructors …

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/pdf/SkPDFDevice.cpp

Issue 12387086: Unwind PDFObject destructor calls into heap instead of stack. Notice: the order of the destructors … (Closed) Base URL: http://skia.googlecode.com/svn/trunk/

Patch Set: Created 7 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: src/pdf/SkPDFDevice.cpp

===================================================================

--- src/pdf/SkPDFDevice.cpp (revision 8010)

+++ src/pdf/SkPDFDevice.cpp (working copy)

@@ -645,7 +645,14 @@

fShaderResources.unrefAll();

SkSafeUnref(fAnnotations);

SkSafeUnref(fResourceDict);

+ /*

+ // Transfer ownership of fResourceDict to list.

+ SkTDArray<SkPDFObject*> list;

+ list.push(fResourceDict);

+ fResourceDict = NULL;

+ SkPDFObject::safeUnref(&list);

+ */

if (clearFontUsage) {

fFontGlyphUsage->reset();

}

« no previous file with comments | « no previous file | src/pdf/SkPDFFormXObject.cpp » ('j') | no next file with comments »