Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1186)

Unified Diff: chrome/browser/extensions/api/messaging/native_message_process_host_unittest.cc

Issue 12386018: Revert 185189. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src/
Patch Set: Created 7 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/extensions/api/messaging/native_message_process_host_unittest.cc
===================================================================
--- chrome/browser/extensions/api/messaging/native_message_process_host_unittest.cc (revision 185206)
+++ chrome/browser/extensions/api/messaging/native_message_process_host_unittest.cc (working copy)
@@ -33,7 +33,6 @@
namespace {
-const char kTestHostId[] = "knldjmfmopnpolahpmmgbagdohdnhkik";
const char kTestMessage[] = "{\"text\": \"Hello.\"}";
base::FilePath GetTestDir() {
@@ -62,8 +61,7 @@
NULL, NULL);
}
- virtual void Launch(const GURL& origin,
- const std::string& native_host_name,
+ virtual void Launch(const std::string& native_host_name,
LaunchedCallback callback) const OVERRIDE {
callback.Run(base::GetCurrentProcessHandle(), read_file_, write_file_);
}
@@ -153,7 +151,7 @@
scoped_ptr<NativeProcessLauncher> launcher(
new FakeLauncher(temp_input_file, temp_output_file));
native_message_process_host_ = NativeMessageProcessHost::CreateWithLauncher(
- AsWeakPtr(), kTestHostId, "empty_app.py", 0, launcher.Pass());
+ AsWeakPtr(), "empty_app.py", 0, launcher.Pass());
ASSERT_TRUE(native_message_process_host_.get());
message_loop_.RunUntilIdle();
@@ -171,7 +169,7 @@
scoped_ptr<NativeProcessLauncher> launcher(
new FakeLauncher(temp_input_file, temp_output_file));
native_message_process_host_ = NativeMessageProcessHost::CreateWithLauncher(
- AsWeakPtr(), kTestHostId, "empty_app.py", 0, launcher.Pass());
+ AsWeakPtr(), "empty_app.py", 0, launcher.Pass());
ASSERT_TRUE(native_message_process_host_.get());
message_loop_.RunUntilIdle();
@@ -195,7 +193,7 @@
// it recieved.
TEST_F(NativeMessagingTest, DISABLED_EchoConnect) {
native_message_process_host_ = NativeMessageProcessHost::Create(
- AsWeakPtr(), kTestHostId, "empty_app.py", 0);
+ AsWeakPtr(), "empty_app.py", 0);
ASSERT_TRUE(native_message_process_host_.get());
message_loop_.RunUntilIdle();

Powered by Google App Engine
This is Rietveld 408576698