Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1416)

Unified Diff: chrome/browser/extensions/api/messaging/native_message_process_host.h

Issue 12386018: Revert 185189. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src/
Patch Set: Created 7 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/extensions/api/messaging/native_message_process_host.h
===================================================================
--- chrome/browser/extensions/api/messaging/native_message_process_host.h (revision 185206)
+++ chrome/browser/extensions/api/messaging/native_message_process_host.h (working copy)
@@ -40,7 +40,8 @@
#endif // !defined(OS_POSIX)
{
public:
- // Interface for the object that receives messages from the native process.
+ // Interface for classes that which to recieve messages from the native
+ // process.
class Client {
public:
virtual ~Client() {}
@@ -54,14 +55,12 @@
static scoped_ptr<NativeMessageProcessHost> Create(
base::WeakPtr<Client> weak_client_ui,
- const std::string& source_extension_id,
const std::string& native_host_name,
int destination_port);
// Create using specified |launcher|. Used in tests.
static scoped_ptr<NativeMessageProcessHost> CreateWithLauncher(
base::WeakPtr<Client> weak_client_ui,
- const std::string& source_extension_id,
const std::string& native_host_name,
int destination_port,
scoped_ptr<NativeProcessLauncher> launcher);
@@ -81,7 +80,6 @@
private:
NativeMessageProcessHost(base::WeakPtr<Client> weak_client_ui,
- const std::string& source_extension_id,
const std::string& native_host_name,
int destination_port,
scoped_ptr<NativeProcessLauncher> launcher);
@@ -117,9 +115,6 @@
// UI thread.
base::WeakPtr<Client> weak_client_ui_;
- // ID of the calling extension.
- std::string source_extension_id_;
-
// Name of the native messaging host.
std::string native_host_name_;

Powered by Google App Engine
This is Rietveld 408576698