Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(454)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1237833003: Update slave scripts to set skia_arch_type but not skia_arch_width (Closed)

Created:
5 years, 5 months ago by bsalomon
Modified:
5 years, 2 months ago
Reviewers:
borenet
CC:
chromium-reviews, kjellander-cc_chromium.org, stip+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/tools/build.git@master
Target Ref:
refs/heads/master
Project:
build
Visibility:
Public.

Description

Update slave scripts to set skia_arch_type but not skia_arch_width Necessary to land https://codereview.chromium.org/1228553010/ in Skia. BUG=skia:4042 Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=296125

Patch Set 1 #

Patch Set 2 : rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+59 lines, -62 lines) Patch
M scripts/slave/recipe_modules/skia/config.py View 1 2 chunks +11 lines, -14 lines 0 comments Download
M scripts/slave/recipes/skia/skia.expected/Build-Mac10.8-Clang-Arm7-Debug-Android.json View 1 chunk +1 line, -1 line 0 comments Download
M scripts/slave/recipes/skia/skia.expected/Build-Ubuntu-GCC-Arm7-Debug-Android_FrameworkDefs.json View 1 1 chunk +2 lines, -2 lines 0 comments Download
M scripts/slave/recipes/skia/skia.expected/Build-Ubuntu-GCC-Arm7-Debug-Android_NoNeon.json View 1 chunk +1 line, -1 line 0 comments Download
M scripts/slave/recipes/skia/skia.expected/Build-Ubuntu-GCC-Arm7-Debug-CrOS_Daisy.json View 1 chunk +1 line, -1 line 0 comments Download
M scripts/slave/recipes/skia/skia.expected/Build-Ubuntu-GCC-Arm7-Debug-CrOS_Link.json View 1 chunk +1 line, -1 line 0 comments Download
M scripts/slave/recipes/skia/skia.expected/Build-Ubuntu-GCC-x86_64-Release-Mesa.json View 1 chunk +1 line, -1 line 0 comments Download
M scripts/slave/recipes/skia/skia.expected/Build-Win-MSVC-x86-Debug.json View 1 chunk +1 line, -1 line 0 comments Download
M scripts/slave/recipes/skia/skia.expected/Build-Win-MSVC-x86-Debug-Exceptions.json View 1 chunk +1 line, -1 line 0 comments Download
M scripts/slave/recipes/skia/skia.expected/Build-Win-MSVC-x86-Debug-GDI.json View 1 chunk +1 line, -1 line 0 comments Download
M scripts/slave/recipes/skia/skia.expected/Perf-Android-GCC-Nexus7-GPU-Tegra3-Arm7-Release.json View 1 1 chunk +1 line, -1 line 0 comments Download
M scripts/slave/recipes/skia/skia.expected/Perf-Win8-MSVC-ShuttleB-GPU-HD4600-x86_64-Release-Trybot.json View 1 1 chunk +1 line, -1 line 0 comments Download
M scripts/slave/recipes/skia/skia.expected/Test-ChromeOS-GCC-Link-CPU-AVX-x86_64-Debug.json View 1 2 chunks +2 lines, -2 lines 0 comments Download
M scripts/slave/recipes/skia/skia.expected/Test-Mac10.8-Clang-MacMini4.1-GPU-GeForce320M-x86_64-Release.json View 1 2 chunks +2 lines, -2 lines 0 comments Download
M scripts/slave/recipes/skia/skia.expected/Test-Ubuntu-GCC-GCE-CPU-AVX2-x86_64-Release-SKNX_NO_SIMD.json View 1 2 chunks +2 lines, -2 lines 0 comments Download
M scripts/slave/recipes/skia/skia.expected/Test-Ubuntu-GCC-GCE-CPU-AVX2-x86_64-Release-Shared.json View 1 2 chunks +2 lines, -2 lines 0 comments Download
M scripts/slave/recipes/skia/skia.expected/Test-Ubuntu-GCC-GCE-CPU-AVX2-x86_64-Release-TSAN.json View 1 2 chunks +2 lines, -2 lines 0 comments Download
M scripts/slave/recipes/skia/skia.expected/Test-Ubuntu-GCC-ShuttleA-GPU-GTX550Ti-x86_64-Debug-ZeroGPUCache.json View 1 2 chunks +2 lines, -2 lines 0 comments Download
M scripts/slave/recipes/skia/skia.expected/Test-Ubuntu-GCC-ShuttleA-GPU-GTX550Ti-x86_64-Release-Valgrind.json View 1 2 chunks +2 lines, -2 lines 0 comments Download
M scripts/slave/recipes/skia/skia.expected/Test-Win8-MSVC-ShuttleA-CPU-AVX-x86_64-Debug.json View 1 2 chunks +2 lines, -2 lines 0 comments Download
M scripts/slave/recipes/skia/skia.expected/Test-Win8-MSVC-ShuttleB-GPU-HD4600-x86-Release-ANGLE.json View 1 2 chunks +2 lines, -2 lines 0 comments Download
M scripts/slave/recipes/skia/skia.expected/Test-iOS-Clang-iPad4-GPU-SGX554-Arm7-Debug.json View 1 1 chunk +1 line, -1 line 0 comments Download
M scripts/slave/recipes/skia/skia.expected/download_and_push_skimage.json View 1 2 chunks +2 lines, -2 lines 0 comments Download
M scripts/slave/recipes/skia/skia.expected/download_and_push_skps.json View 1 2 chunks +2 lines, -2 lines 0 comments Download
M scripts/slave/recipes/skia/skia.expected/failed_dm.json View 1 2 chunks +2 lines, -2 lines 0 comments Download
M scripts/slave/recipes/skia/skia.expected/failed_get_hashes.json View 1 2 chunks +2 lines, -2 lines 0 comments Download
M scripts/slave/recipes/skia/skia.expected/has_ccache_android.json View 1 chunk +1 line, -1 line 0 comments Download
M scripts/slave/recipes/skia/skia.expected/missing_SKIMAGE_VERSION_device.json View 1 2 chunks +2 lines, -2 lines 0 comments Download
M scripts/slave/recipes/skia/skia.expected/missing_SKIMAGE_VERSION_host.json View 1 2 chunks +2 lines, -2 lines 0 comments Download
M scripts/slave/recipes/skia/skia.expected/missing_SKP_VERSION_device.json View 1 2 chunks +2 lines, -2 lines 0 comments Download
M scripts/slave/recipes/skia/skia.expected/missing_SKP_VERSION_host.json View 1 2 chunks +2 lines, -2 lines 0 comments Download

Messages

Total messages: 11 (5 generated)
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1237833003/1
5 years, 5 months ago (2015-07-14 17:48:34 UTC) #2
bsalomon
5 years, 5 months ago (2015-07-14 17:48:53 UTC) #4
borenet
LGTM
5 years, 5 months ago (2015-07-14 17:54:22 UTC) #5
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
5 years, 5 months ago (2015-07-14 17:55:04 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1237833003/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1237833003/20001
5 years, 4 months ago (2015-07-27 13:00:37 UTC) #10
commit-bot: I haz the power
5 years, 4 months ago (2015-07-27 13:03:39 UTC) #11
Message was sent while issue was closed. 
Committed patchset #2 (id:20001) as
http://src.chromium.org/viewvc/chrome?view=rev&revision=296125

Powered by Google App Engine
This is Rietveld 408576698