scripts/slave/recipes/skia/skia.expected/missing_SKP_VERSION_host.json - Issue 1237833003: Update slave scripts to set skia_arch_type but not skia_arch_width

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: scripts/slave/recipes/skia/skia.expected/missing_SKP_VERSION_host.json

Issue 1237833003: Update slave scripts to set skia_arch_type but not skia_arch_width (Closed) Base URL: https://chromium.googlesource.com/chromium/tools/build.git@master

Patch Set: rebase Created 5 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: scripts/slave/recipes/skia/skia.expected/missing_SKP_VERSION_host.json

diff --git a/scripts/slave/recipes/skia/skia.expected/missing_SKP_VERSION_host.json b/scripts/slave/recipes/skia/skia.expected/missing_SKP_VERSION_host.json

index 7d00a4bba132f7f764fb5ab643ccc89026d01c14..d4981ecc5b212161af6d036525fa16604c633ef6 100644

--- a/scripts/slave/recipes/skia/skia.expected/missing_SKP_VERSION_host.json

+++ b/scripts/slave/recipes/skia/skia.expected/missing_SKP_VERSION_host.json

@@ -95,7 +95,7 @@

"cwd": "[SLAVE_BUILD]/skia",

"env": {

"CHROME_PATH": "/home/chrome-bot/src",

- "GYP_DEFINES": "skia_arch_type=x86_64 skia_arch_width=64 skia_gpu=0 skia_warnings_as_errors=0",

+ "GYP_DEFINES": "skia_arch_type=x86_64 skia_gpu=0 skia_warnings_as_errors=0",

"SKIA_OUT": "[SLAVE_BUILD]/skia/out/Test-Ubuntu-GCC-GCE-CPU-AVX2-x86_64-Debug"

"name": "build dm"

@@ -109,7 +109,7 @@