scripts/slave/recipes/skia/skia.expected/missing_SKP_VERSION_device.json - Issue 1237833003: Update slave scripts to set skia_arch_type but not skia_arch_width

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: scripts/slave/recipes/skia/skia.expected/missing_SKP_VERSION_device.json

Issue 1237833003: Update slave scripts to set skia_arch_type but not skia_arch_width (Closed) Base URL: https://chromium.googlesource.com/chromium/tools/build.git@master

Patch Set: rebase Created 5 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « scripts/slave/recipes/skia/skia.expected/missing_SKIMAGE_VERSION_host.json ('k') | scripts/slave/recipes/skia/skia.expected/missing_SKP_VERSION_host.json » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: scripts/slave/recipes/skia/skia.expected/missing_SKP_VERSION_device.json

diff --git a/scripts/slave/recipes/skia/skia.expected/missing_SKP_VERSION_device.json b/scripts/slave/recipes/skia/skia.expected/missing_SKP_VERSION_device.json

index 136e00bdd17c7fe2a6ad7807cc25baaf81f0fef5..fac93da216ec34bc6520773ea9a9983891eda813 100644

--- a/scripts/slave/recipes/skia/skia.expected/missing_SKP_VERSION_device.json

+++ b/scripts/slave/recipes/skia/skia.expected/missing_SKP_VERSION_device.json

@@ -93,7 +93,7 @@

"ANDROID_HOME": "/home/chrome-bot/android-sdk-linux",

"ANDROID_SDK_ROOT": "/home/chrome-bot/android-sdk-linux",

"BUILDTYPE": "Debug",

- "GYP_DEFINES": "skia_arch_type=arm skia_arch_width=32 skia_warnings_as_errors=0",

+ "GYP_DEFINES": "skia_arch_type=arm skia_warnings_as_errors=0",

"SKIA_ANDROID_VERBOSE_SETUP": "1",

"SKIA_OUT": "[SLAVE_BUILD]/skia/out/Test-Android-GCC-Nexus7-GPU-Tegra3-Arm7-Debug"

@@ -111,7 +111,7 @@