Cut the spam in sky log printouts.

Cut the spam in the sky log printouts.

This is a port of
https://github.com/domokit/mojo/commit/f61746083fee43866e7905d96fbb9becc8d6af64
.

This patch eliminates the tag "[0708/123945:INFO:builtin_natives.cc(86)]
CONSOLE" prefixing each message in sky log Android output by
implementing the Android logging directly, ie. without base LOG macros.

The log message is now written directly to stdout on Android as well as
on Linux and iOS, and is also written to android logcat tagged as
"chromium", which is the tag we use to pick up native LOG messages from
the logcat when running on unrooted device.

A user running `mojo_shell.py --sky` on a rooted device will now see:

  hello

instead of

  [0715/174636:INFO:builtin_natives.cc(86)] CONSOLE: hello

A user running `mojo_shell.py --sky` on unrooted device will now see:

  I/chromium(29585): hello

instead of

  I/chromium(26587): [0715/174636:INFO:builtin_natives.cc(86)] CONSOLE: hello

Fixes #317.

R=abarth@chromium.org

Committed: https://chromium.googlesource.com/external/mojo/+/f409a9cc36b48da1853b1074b30be8e526d11cd3

[ppi, 2015-07-16 11:06:14]

ppi@chromium.org changed reviewers:
+ abarth@chromium.org

[ppi, 2015-07-16 11:08:52]

Hi Adam,

this would match what we did for the dart content handler in
https://codereview.chromium.org/1239583004/. I am not sure though what is the
right thing to do for iOS - how does the developer access the console output
there? If writing to stdout is enough we should be good with the patch as it is.

[abarth-chromium, 2015-07-16 14:17:55]

LGTM

https://codereview.chromium.org/1237403002/diff/1/sky/engine/bindings/builtin...
File sky/engine/bindings/builtin_natives.cc (right):

https://codereview.chromium.org/1237403002/diff/1/sky/engine/bindings/builtin...
sky/engine/bindings/builtin_natives.cc:174: // logcat output to host terminal.
Please remove this sentence about the "chromium" tag.  We're not part of the
Chromium project.

https://codereview.chromium.org/1237403002/diff/1/sky/engine/bindings/builtin...
sky/engine/bindings/builtin_natives.cc:175:
__android_log_print(ANDROID_LOG_INFO, "chromium", "%.*s", length, chars);
s/chromium/sky/

[ppi, 2015-07-16 16:17:19]

Patchset #2 (id:20001) has been deleted

[ppi, 2015-07-16 16:18:47]

https://codereview.chromium.org/1237403002/diff/1/sky/engine/bindings/builtin...
File sky/engine/bindings/builtin_natives.cc (right):

https://codereview.chromium.org/1237403002/diff/1/sky/engine/bindings/builtin...
sky/engine/bindings/builtin_natives.cc:174: // logcat output to host terminal.
On 2015/07/16 14:17:55, abarth-chromium wrote:
> Please remove this sentence about the "chromium" tag.  We're not part of the
> Chromium project.

Done.

https://codereview.chromium.org/1237403002/diff/1/sky/engine/bindings/builtin...
sky/engine/bindings/builtin_natives.cc:175:
__android_log_print(ANDROID_LOG_INFO, "chromium", "%.*s", length, chars);
On 2015/07/16 14:17:55, abarth-chromium wrote:
> s/chromium/sky/

Done.

[ppi, 2015-07-16 16:19:06]

Committed patchset #2 (id:40001) manually as
f409a9cc36b48da1853b1074b30be8e526d11cd3 (presubmit successful).