Cut the spam in the dart handler log printouts.

Cut the spam in the dart handler log printouts.

This patch eliminates the tag "[0708/123945:INFO:builtin_natives.cc(86)]
CONSOLE "prefixing each message in dart content handler log Android
output by implementing the Android logging directly, ie. without base
LOG macros.

The log message is now written directly to stdout on Android as well as
on Linux, and also written to android logcat tagged as "chromium", which
is the tag we use to pick up native LOG messages from the logcat when
running on unrooted device.

A user running mojo_shell.py on a rooted device will now see:

  hello

instead of

  [0715/174636:INFO:builtin_natives.cc(86)] CONSOLE: hello

A user running mojo_shell.py on unrooted device will now see:

  I/chromium(29585): hello

instead of

  I/chromium(26587): [0715/174636:INFO:builtin_natives.cc(86)] CONSOLE: hello

Fixes #309.

R=qsr@chromium.org

Committed: https://chromium.googlesource.com/external/mojo/+/f61746083fee43866e7905d96fbb9becc8d6af64

[ppi, 2015-07-15 16:23:32]

ppi@chromium.org changed reviewers:
+ qsr@chromium.org

[ppi, 2015-07-15 16:24:27]

Hi Ben,

ptal.

[qsr, 2015-07-16 08:31:39]

LGTM with nits.

https://codereview.chromium.org/1239583004/diff/1/mojo/dart/embedder/builtin_...
File mojo/dart/embedder/builtin_natives.cc (right):

https://codereview.chromium.org/1239583004/diff/1/mojo/dart/embedder/builtin_...
mojo/dart/embedder/builtin_natives.cc:99: __android_log_print(ANDROID_LOG_INFO,
"chromium", str_newline.c_str());
Do android_log_print needs a carriage return? From what I can read you do not
need it.
You should be able to use:
__android_log_print(ANDROID_LOG_INFO, "chromium", "%.*s", length, chars);

[ppi, 2015-07-16 09:41:27]

Thanks!

https://codereview.chromium.org/1239583004/diff/1/mojo/dart/embedder/builtin_...
File mojo/dart/embedder/builtin_natives.cc (right):

https://codereview.chromium.org/1239583004/diff/1/mojo/dart/embedder/builtin_...
mojo/dart/embedder/builtin_natives.cc:99: __android_log_print(ANDROID_LOG_INFO,
"chromium", str_newline.c_str());
On 2015/07/16 08:31:39, qsr wrote:
> Do android_log_print needs a carriage return? From what I can read you do not
> need it.
> You should be able to use:
> __android_log_print(ANDROID_LOG_INFO, "chromium", "%.*s", length, chars);

Yes indeed, done.

[ppi, 2015-07-16 09:41:41]

Committed patchset #2 (id:20001) manually as
f61746083fee43866e7905d96fbb9becc8d6af64 (presubmit successful).