Cut the spam in sky log printouts.

sky/engine/bindings/builtin_natives.cc

 // Copyright 2014 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "sky/engine/bindings/builtin_natives.h"
 
 #include <stdio.h>
 #include <stdlib.h>
 #include <string.h>
 
 #include "base/bind.h"
 #include "base/logging.h"
 #include "base/macros.h"
 #include "base/time/time.h"
 #include "dart/runtime/include/dart_api.h"
 #include "sky/engine/bindings/builtin.h"
 #include "sky/engine/core/dom/Microtask.h"
 #include "sky/engine/core/script/dom_dart_state.h"
 #include "sky/engine/tonic/dart_api_scope.h"
 #include "sky/engine/tonic/dart_builtin.h"
 #include "sky/engine/tonic/dart_error.h"
 #include "sky/engine/tonic/dart_invoke.h"
 #include "sky/engine/tonic/dart_isolate_scope.h"
 #include "sky/engine/tonic/dart_state.h"
 #include "sky/engine/tonic/dart_timer_heap.h"
 #include "sky/engine/tonic/dart_value.h"
 #include "sky/engine/wtf/text/WTFString.h"
 
+#if defined(OS_ANDROID)
+#include <android/log.h>
+#endif
+
 namespace blink {
 
 #define REGISTER_FUNCTION(name, count)                                         \
   { "" #name, name, count },
 #define DECLARE_FUNCTION(name, count)                                          \
   extern void name(Dart_NativeArguments args);
 
 // Lists the native functions implementing basic functionality in
 // the Mojo embedder dart, such as printing, and file I/O.
 #define BUILTIN_NATIVE_LIST(V) \
@@ skipping 113 matching lines @@
 // Implementation of native functions which are used for some
 // test/debug functionality in standalone dart mode.
 void Logger_PrintString(Dart_NativeArguments args) {
   intptr_t length = 0;
   uint8_t* chars = nullptr;
   Dart_Handle str = Dart_GetNativeArgument(args, 0);
   Dart_Handle result = Dart_StringToUTF8(str, &chars, &length);
   if (Dart_IsError(result)) {
     Dart_PropagateError(result);
   } else {
-
-  String message(chars, length);
-  // TODO(dart): Hook up to developer console (if/when that's a thing).
-#if OS(ANDROID) || OS(IOS)
-    LOG(INFO) << "CONSOLE: " << message.utf8().data();
-#else
-    printf("CONSOLE: %s\n", message.utf8().data());
-    fflush(stdout);
+    // Uses fwrite to support printing NUL bytes.
+    fwrite(chars, 1, length, stdout);
+    fputs("\n", stdout);
+#if defined(OS_ANDROID)
+    // In addition to writing to the stdout, write to the logcat so that the
+    // message is discoverable when running on an unrooted device.
+    __android_log_print(ANDROID_LOG_INFO, "sky", "%.*s", length, chars);
 #endif
   }
 }
 
 static void ExecuteMicrotask(base::WeakPtr<DartState> dart_state,
                              RefPtr<DartValue> callback) {
   if (!dart_state)
     return;
   DartIsolateScope scope(dart_state->isolate());
   DartApiScope api_scope;
@@ skipping 39 matching lines @@
 void Timer_cancel(Dart_NativeArguments args) {
   int64_t timer_id = 0;
   DART_CHECK_VALID(Dart_GetNativeIntegerArgument(args, 0, &timer_id));
 
   DartState* state = DartState::Current();
   CHECK(state);
   state->timer_heap().Remove(timer_id);
 }
 
 }  // namespace blink