Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1554)

Issue 1237063002: Allocate XMLHttpRequest on the eagerly finalized heap. (Closed)

Created:
5 years, 5 months ago by sof
Modified:
5 years, 5 months ago
Reviewers:
oilpan-reviews, haraken
CC:
blink-reviews, tyoshino+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Target Ref:
refs/heads/master
Project:
blink
Visibility:
Public.

Description

Allocate XMLHttpRequest on the eagerly finalized heap. With XMLHttpRequest now being on the heap with !ENABLE(OILPAN), we need to arrange for this ActiveDOMObject to be allocated as an eagerly finalized object. R=haraken BUG=509841 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=198853

Patch Set 1 #

Patch Set 2 : add macro for testing eager finalization #

Patch Set 3 : add macro for testing eager finalization #

Unified diffs Side-by-side diffs Delta from patch set Stats (+14 lines, -1 line) Patch
M Source/core/xmlhttprequest/XMLHttpRequest.h View 1 chunk +6 lines, -0 lines 0 comments Download
M Source/core/xmlhttprequest/XMLHttpRequest.cpp View 1 1 chunk +5 lines, -0 lines 0 comments Download
M Source/platform/heap/Heap.h View 1 2 2 chunks +3 lines, -1 line 0 comments Download

Messages

Total messages: 11 (4 generated)
sof
please take a look. Affects trunk builds (and M45..)
5 years, 5 months ago (2015-07-14 09:00:33 UTC) #2
haraken
LGTM
5 years, 5 months ago (2015-07-14 09:05:47 UTC) #3
haraken
How did you notice this error?
5 years, 5 months ago (2015-07-14 09:06:05 UTC) #5
sof
On 2015/07/14 09:06:05, haraken wrote: > How did you notice this error? By looking at ...
5 years, 5 months ago (2015-07-14 09:08:48 UTC) #6
sof
On 2015/07/14 09:00:33, sof wrote: > please take a look. > > Affects trunk builds ...
5 years, 5 months ago (2015-07-14 09:12:17 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1237063002/40001
5 years, 5 months ago (2015-07-14 09:50:53 UTC) #10
commit-bot: I haz the power
5 years, 5 months ago (2015-07-14 10:56:07 UTC) #11
Message was sent while issue was closed.
Committed patchset #3 (id:40001) as
https://src.chromium.org/viewvc/blink?view=rev&revision=198853

Powered by Google App Engine
This is Rietveld 408576698