Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(88)

Side by Side Diff: Source/core/xmlhttprequest/XMLHttpRequest.cpp

Issue 1237063002: Allocate XMLHttpRequest on the eagerly finalized heap. (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master
Patch Set: add macro for testing eager finalization Created 5 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « Source/core/xmlhttprequest/XMLHttpRequest.h ('k') | Source/platform/heap/Heap.h » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 /* 1 /*
2 * Copyright (C) 2004, 2006, 2008 Apple Inc. All rights reserved. 2 * Copyright (C) 2004, 2006, 2008 Apple Inc. All rights reserved.
3 * Copyright (C) 2005-2007 Alexey Proskuryakov <ap@webkit.org> 3 * Copyright (C) 2005-2007 Alexey Proskuryakov <ap@webkit.org>
4 * Copyright (C) 2007, 2008 Julien Chaffraix <jchaffraix@webkit.org> 4 * Copyright (C) 2007, 2008 Julien Chaffraix <jchaffraix@webkit.org>
5 * Copyright (C) 2008, 2011 Google Inc. All rights reserved. 5 * Copyright (C) 2008, 2011 Google Inc. All rights reserved.
6 * Copyright (C) 2012 Intel Corporation 6 * Copyright (C) 2012 Intel Corporation
7 * 7 *
8 * This library is free software; you can redistribute it and/or 8 * This library is free software; you can redistribute it and/or
9 * modify it under the terms of the GNU Lesser General Public 9 * modify it under the terms of the GNU Lesser General Public
10 * License as published by the Free Software Foundation; either 10 * License as published by the Free Software Foundation; either
(...skipping 206 matching lines...) Expand 10 before | Expand all | Expand 10 after
217 , m_error(false) 217 , m_error(false)
218 , m_uploadEventsAllowed(true) 218 , m_uploadEventsAllowed(true)
219 , m_uploadComplete(false) 219 , m_uploadComplete(false)
220 , m_sameOriginRequest(true) 220 , m_sameOriginRequest(true)
221 , m_downloadingToFile(false) 221 , m_downloadingToFile(false)
222 , m_responseTextOverflow(false) 222 , m_responseTextOverflow(false)
223 { 223 {
224 #ifndef NDEBUG 224 #ifndef NDEBUG
225 xmlHttpRequestCounter.increment(); 225 xmlHttpRequestCounter.increment();
226 #endif 226 #endif
227 #if ENABLE(ASSERT) && !ENABLE(OILPAN)
228 // Verify that this object was allocated on the 'eager' heap.
229 // (this check comes 'for free' with Oilpan enabled.)
230 ASSERT(IS_EAGERLY_FINALIZED());
231 #endif
227 } 232 }
228 233
229 XMLHttpRequest::~XMLHttpRequest() 234 XMLHttpRequest::~XMLHttpRequest()
230 { 235 {
231 #ifndef NDEBUG 236 #ifndef NDEBUG
232 xmlHttpRequestCounter.decrement(); 237 xmlHttpRequestCounter.decrement();
233 #endif 238 #endif
234 } 239 }
235 240
236 Document* XMLHttpRequest::document() const 241 Document* XMLHttpRequest::document() const
(...skipping 1430 matching lines...) Expand 10 before | Expand all | Expand 10 after
1667 visitor->trace(m_responseDocumentParser); 1672 visitor->trace(m_responseDocumentParser);
1668 visitor->trace(m_progressEventThrottle); 1673 visitor->trace(m_progressEventThrottle);
1669 visitor->trace(m_upload); 1674 visitor->trace(m_upload);
1670 visitor->trace(m_blobLoader); 1675 visitor->trace(m_blobLoader);
1671 XMLHttpRequestEventTarget::trace(visitor); 1676 XMLHttpRequestEventTarget::trace(visitor);
1672 DocumentParserClient::trace(visitor); 1677 DocumentParserClient::trace(visitor);
1673 ActiveDOMObject::trace(visitor); 1678 ActiveDOMObject::trace(visitor);
1674 } 1679 }
1675 1680
1676 } // namespace blink 1681 } // namespace blink
OLDNEW
« no previous file with comments | « Source/core/xmlhttprequest/XMLHttpRequest.h ('k') | Source/platform/heap/Heap.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698