Source/core/xmlhttprequest/XMLHttpRequest.cpp - Issue 1237063002: Allocate XMLHttpRequest on the eagerly finalized heap.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/core/xmlhttprequest/XMLHttpRequest.cpp

Issue 1237063002: Allocate XMLHttpRequest on the eagerly finalized heap. (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: add macro for testing eager finalization Created 5 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: Source/core/xmlhttprequest/XMLHttpRequest.cpp

diff --git a/Source/core/xmlhttprequest/XMLHttpRequest.cpp b/Source/core/xmlhttprequest/XMLHttpRequest.cpp

index 239b35139a9d28652532e21320bec285f22c2ebf..23a3ec5b64f1be5377d2d693bcbdaac11c7ac66a 100644

--- a/Source/core/xmlhttprequest/XMLHttpRequest.cpp

+++ b/Source/core/xmlhttprequest/XMLHttpRequest.cpp

@@ -224,6 +224,11 @@ XMLHttpRequest::XMLHttpRequest(ExecutionContext* context, PassRefPtr<SecurityOri

#ifndef NDEBUG

xmlHttpRequestCounter.increment();

#endif

+#if ENABLE(ASSERT) && !ENABLE(OILPAN)

+ // Verify that this object was allocated on the 'eager' heap.

+ // (this check comes 'for free' with Oilpan enabled.)

+ ASSERT(IS_EAGERLY_FINALIZED());

+#endif

}

XMLHttpRequest::~XMLHttpRequest()

« no previous file with comments | « Source/core/xmlhttprequest/XMLHttpRequest.h ('k') | Source/platform/heap/Heap.h » ('j') | no next file with comments »