Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(24)

Issue 1236793005: Always include floating children into visual overflow (Closed)

Created:
5 years, 5 months ago by Xianzhu
Modified:
5 years, 4 months ago
CC:
blink-reviews, pdr+renderingwatchlist_chromium.org, zoltan1, szager+layoutwatch_chromium.org, eae+blinkwatch, leviw+renderwatch, blink-reviews-rendering, jchaffraix+rendering
Target Ref:
refs/heads/master
Project:
blink
Visibility:
Public.

Description

Always include floating children into visual overflow Previously we have conditions of whether to include floating children into visual overflow. This makes the recalculation of visual overflow depending on the change of the conditions. We could recalc visual overflow on every change of the conditions, but that looks fragile. With this CL we always include floating children into visual overflow. This fixes the first half of bug 507590 (summarized in https://code.google.com/p/chromium/issues/detail?id=507590#c5). Because of the second half of the bug, the added test is still failing. BUG=507590 TEST=fast/block/float/containing-block-change-compositing.html (still fails) Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=198977

Patch Set 1 #

Patch Set 2 : NeedsRebaselines (see the try job results of the previous patch set for expectation changes) #

Unified diffs Side-by-side diffs Delta from patch set Stats (+44 lines, -11 lines) Patch
M LayoutTests/TestExpectations View 1 1 chunk +9 lines, -0 lines 0 comments Download
A LayoutTests/fast/block/float/containing-block-change-compositing.html View 1 chunk +18 lines, -0 lines 0 comments Download
A LayoutTests/fast/block/float/containing-block-change-compositing-expected.html View 1 chunk +7 lines, -0 lines 0 comments Download
M Source/core/layout/LayoutBlock.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/layout/LayoutBlock.cpp View 3 chunks +3 lines, -3 lines 0 comments Download
M Source/core/layout/LayoutBlockFlow.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/layout/LayoutBlockFlow.cpp View 1 chunk +3 lines, -4 lines 0 comments Download
M Source/core/layout/LayoutTableSection.cpp View 2 chunks +2 lines, -2 lines 0 comments Download

Messages

Total messages: 7 (3 generated)
Xianzhu
5 years, 5 months ago (2015-07-15 18:13:57 UTC) #2
eae
LGTM
5 years, 5 months ago (2015-07-15 18:18:50 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1236793005/20001
5 years, 5 months ago (2015-07-15 19:40:27 UTC) #5
commit-bot: I haz the power
5 years, 5 months ago (2015-07-15 19:45:12 UTC) #6
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://src.chromium.org/viewvc/blink?view=rev&revision=198977

Powered by Google App Engine
This is Rietveld 408576698