Source/core/layout/LayoutBlockFlow.cpp - Issue 1236793005: Always include floating children into visual overflow

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/core/layout/LayoutBlockFlow.cpp

Issue 1236793005: Always include floating children into visual overflow (Closed) Base URL: svn://svn.chromium.org/blink/trunk

Patch Set: NeedsRebaselines (see the try job results of the previous patch set for expectation changes) Created 5 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: Source/core/layout/LayoutBlockFlow.cpp

diff --git a/Source/core/layout/LayoutBlockFlow.cpp b/Source/core/layout/LayoutBlockFlow.cpp

index 6def5acfdc7522184a2e0f307299ee1f25724e05..7bb4ad9a4e9ae66c2556691244488868a59f3069 100644

--- a/Source/core/layout/LayoutBlockFlow.cpp

+++ b/Source/core/layout/LayoutBlockFlow.cpp

@@ -1699,11 +1699,10 @@ void LayoutBlockFlow::addOverflowFromFloats()

}

-void LayoutBlockFlow::computeOverflow(LayoutUnit oldClientAfterEdge, bool recomputeFloats)

+void LayoutBlockFlow::computeOverflow(LayoutUnit oldClientAfterEdge)

{

- LayoutBlock::computeOverflow(oldClientAfterEdge, recomputeFloats);

- if (recomputeFloats || createsNewFormattingContext() || hasSelfPaintingLayer())

- addOverflowFromFloats();

+ LayoutBlock::computeOverflow(oldClientAfterEdge);

+ addOverflowFromFloats();

}

RootInlineBox* LayoutBlockFlow::createAndAppendRootInlineBox()

« no previous file with comments | « Source/core/layout/LayoutBlockFlow.h ('k') | Source/core/layout/LayoutTableSection.cpp » ('j') | no next file with comments »