Source/core/layout/LayoutBlock.h - Issue 1236793005: Always include floating children into visual overflow

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/core/layout/LayoutBlock.h

Issue 1236793005: Always include floating children into visual overflow (Closed) Base URL: svn://svn.chromium.org/blink/trunk

Patch Set: NeedsRebaselines (see the try job results of the previous patch set for expectation changes) Created 5 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: Source/core/layout/LayoutBlock.h

diff --git a/Source/core/layout/LayoutBlock.h b/Source/core/layout/LayoutBlock.h

index 87d04120b9044a9b5824d77c6b20a444ef15b962..c8a5077b24dd6dd2db78a69e16ff023712ff50a5 100644

--- a/Source/core/layout/LayoutBlock.h

+++ b/Source/core/layout/LayoutBlock.h

@@ -280,7 +280,7 @@ protected:

virtual void simplifiedNormalFlowLayout();

public:

- virtual void computeOverflow(LayoutUnit oldClientAfterEdge, bool = false);

+ virtual void computeOverflow(LayoutUnit oldClientAfterEdge);

protected:

virtual void addOverflowFromChildren();

void addOverflowFromPositionedObjects();