chrome/browser/extensions/api/web_navigation/web_navigation_api_helpers.h - Issue 1236493004: Final batch adding real histogram values for extension events.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/extensions/api/web_navigation/web_navigation_api_helpers.h

Issue 1236493004: Final batch adding real histogram values for extension events. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: android compile Created 5 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/extensions/api/web_navigation/web_navigation_api.cc ('k') | chrome/browser/extensions/api/web_navigation/web_navigation_api_helpers.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/extensions/api/web_navigation/web_navigation_api_helpers.h

diff --git a/chrome/browser/extensions/api/web_navigation/web_navigation_api_helpers.h b/chrome/browser/extensions/api/web_navigation/web_navigation_api_helpers.h

index ab7890a55934469596da9138a3fb24b0756bcd2d..882cf33623c22ffcfab727de40c57654a2864438 100644

--- a/chrome/browser/extensions/api/web_navigation/web_navigation_api_helpers.h

+++ b/chrome/browser/extensions/api/web_navigation/web_navigation_api_helpers.h

@@ -8,6 +8,7 @@

#include <string>

#include "base/basictypes.h"

+#include "extensions/browser/extension_event_histogram_value.h"

#include "ui/base/page_transition_types.h"

namespace content {

@@ -32,7 +33,8 @@ void DispatchOnBeforeNavigate(content::WebContents* web_contents,

content::RenderFrameHost* frame_host,

const GURL& validated_url);

-void DispatchOnCommitted(const std::string& event_name,

+void DispatchOnCommitted(events::HistogramValue histogram_value,

+ const std::string& event_name,

content::WebContents* web_contents,

content::RenderFrameHost* frame_host,

const GURL& url,