Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(803)

Side by Side Diff: chrome/browser/extensions/api/web_navigation/web_navigation_api_helpers.h

Issue 1236493004: Final batch adding real histogram values for extension events. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: android compile Created 5 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright (c) 2012 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #ifndef CHROME_BROWSER_EXTENSIONS_API_WEB_NAVIGATION_WEB_NAVIGATION_API_HELPERS_ H_ 5 #ifndef CHROME_BROWSER_EXTENSIONS_API_WEB_NAVIGATION_WEB_NAVIGATION_API_HELPERS_ H_
6 #define CHROME_BROWSER_EXTENSIONS_API_WEB_NAVIGATION_WEB_NAVIGATION_API_HELPERS_ H_ 6 #define CHROME_BROWSER_EXTENSIONS_API_WEB_NAVIGATION_WEB_NAVIGATION_API_HELPERS_ H_
7 7
8 #include <string> 8 #include <string>
9 9
10 #include "base/basictypes.h" 10 #include "base/basictypes.h"
11 #include "extensions/browser/extension_event_histogram_value.h"
11 #include "ui/base/page_transition_types.h" 12 #include "ui/base/page_transition_types.h"
12 13
13 namespace content { 14 namespace content {
14 class BrowserContext; 15 class BrowserContext;
15 class RenderFrameHost; 16 class RenderFrameHost;
16 class WebContents; 17 class WebContents;
17 } 18 }
18 19
19 class GURL; 20 class GURL;
20 21
21 namespace extensions { 22 namespace extensions {
22 23
23 namespace web_navigation_api_helpers { 24 namespace web_navigation_api_helpers {
24 25
25 // Returns the frame ID as it will be passed to the extension: 26 // Returns the frame ID as it will be passed to the extension:
26 // 0 if the navigation happens in the main frame, or the frame routing ID 27 // 0 if the navigation happens in the main frame, or the frame routing ID
27 // otherwise. 28 // otherwise.
28 int GetFrameId(content::RenderFrameHost* frame_host); 29 int GetFrameId(content::RenderFrameHost* frame_host);
29 30
30 // Create and dispatch the various events of the webNavigation API. 31 // Create and dispatch the various events of the webNavigation API.
31 void DispatchOnBeforeNavigate(content::WebContents* web_contents, 32 void DispatchOnBeforeNavigate(content::WebContents* web_contents,
32 content::RenderFrameHost* frame_host, 33 content::RenderFrameHost* frame_host,
33 const GURL& validated_url); 34 const GURL& validated_url);
34 35
35 void DispatchOnCommitted(const std::string& event_name, 36 void DispatchOnCommitted(events::HistogramValue histogram_value,
37 const std::string& event_name,
36 content::WebContents* web_contents, 38 content::WebContents* web_contents,
37 content::RenderFrameHost* frame_host, 39 content::RenderFrameHost* frame_host,
38 const GURL& url, 40 const GURL& url,
39 ui::PageTransition transition_type); 41 ui::PageTransition transition_type);
40 42
41 void DispatchOnDOMContentLoaded(content::WebContents* web_contents, 43 void DispatchOnDOMContentLoaded(content::WebContents* web_contents,
42 content::RenderFrameHost* frame_host, 44 content::RenderFrameHost* frame_host,
43 const GURL& url); 45 const GURL& url);
44 46
45 void DispatchOnCompleted(content::WebContents* web_contents, 47 void DispatchOnCompleted(content::WebContents* web_contents,
(...skipping 15 matching lines...) Expand all
61 void DispatchOnTabReplaced( 63 void DispatchOnTabReplaced(
62 content::WebContents* old_web_contents, 64 content::WebContents* old_web_contents,
63 content::BrowserContext* browser_context, 65 content::BrowserContext* browser_context,
64 content::WebContents* new_web_contents); 66 content::WebContents* new_web_contents);
65 67
66 } // namespace web_navigation_api_helpers 68 } // namespace web_navigation_api_helpers
67 69
68 } // namespace extensions 70 } // namespace extensions
69 71
70 #endif // CHROME_BROWSER_EXTENSIONS_API_WEB_NAVIGATION_WEB_NAVIGATION_API_HELPE RS_H_ 72 #endif // CHROME_BROWSER_EXTENSIONS_API_WEB_NAVIGATION_WEB_NAVIGATION_API_HELPE RS_H_
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698