Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(5104)

Unified Diff: chrome/browser/extensions/api/web_navigation/web_navigation_api.cc

Issue 1236493004: Final batch adding real histogram values for extension events. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: android compile Created 5 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/extensions/api/web_navigation/web_navigation_api.cc
diff --git a/chrome/browser/extensions/api/web_navigation/web_navigation_api.cc b/chrome/browser/extensions/api/web_navigation/web_navigation_api.cc
index 83ca7e004670b27d3af4583b1ea24fba458fcc40..2e8522fb0e484f0f6572bcc9d02a8bc66339bad1 100644
--- a/chrome/browser/extensions/api/web_navigation/web_navigation_api.cc
+++ b/chrome/browser/extensions/api/web_navigation/web_navigation_api.cc
@@ -319,21 +319,25 @@ void WebNavigationTabObserver::DidCommitProvisionalLoadForFrame(
if (!navigation_state_.CanSendEvents(render_frame_host))
return;
+ events::HistogramValue histogram_value = events::UNKNOWN;
std::string event_name;
if (is_reference_fragment_navigation) {
+ histogram_value = events::WEB_NAVIGATION_ON_REFERENCE_FRAGMENT_UPDATED;
event_name = web_navigation::OnReferenceFragmentUpdated::kEventName;
} else if (is_history_state_modification) {
+ histogram_value = events::WEB_NAVIGATION_ON_HISTORY_STATE_UPDATED;
event_name = web_navigation::OnHistoryStateUpdated::kEventName;
} else {
if (navigation_state_.GetIsServerRedirected(render_frame_host)) {
transition_type = ui::PageTransitionFromInt(
transition_type | ui::PAGE_TRANSITION_SERVER_REDIRECT);
}
+ histogram_value = events::WEB_NAVIGATION_ON_COMMITTED;
event_name = web_navigation::OnCommitted::kEventName;
}
- helpers::DispatchOnCommitted(event_name, web_contents(), render_frame_host,
- navigation_state_.GetUrl(render_frame_host),
- transition_type);
+ helpers::DispatchOnCommitted(
+ histogram_value, event_name, web_contents(), render_frame_host,
+ navigation_state_.GetUrl(render_frame_host), transition_type);
}
void WebNavigationTabObserver::DidFailProvisionalLoad(

Powered by Google App Engine
This is Rietveld 408576698