Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(291)

Issue 1236403003: [Offline pages] Moving browser code to android path (Closed)

Created:
5 years, 5 months ago by fgorski
Modified:
5 years, 5 months ago
Reviewers:
nyquist
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[Offline pages] Moving browser code to android path BUG=491352 R=nyquist@chromium.org Committed: https://crrev.com/d170f0f75b7b7e3cac4620816a077d2ae8713751 Cr-Commit-Position: refs/heads/master@{#339356}

Patch Set 1 #

Patch Set 2 : Adding unit_tests fixes #

Patch Set 3 : Narrowing the move to archiver only due to another patch moving the rest ot components #

Unified diffs Side-by-side diffs Delta from patch set Stats (+11 lines, -434 lines) Patch
A + chrome/browser/android/offline_pages/BUILD.gn View 1 2 0 chunks +-1 lines, --1 lines 0 comments Download
A + chrome/browser/android/offline_pages/DEPS View 1 2 0 chunks +-1 lines, --1 lines 0 comments Download
A + chrome/browser/android/offline_pages/OWNERS View 1 2 1 chunk +0 lines, -1 line 0 comments Download
A + chrome/browser/android/offline_pages/offline_page_mhtml_archiver.h View 2 chunks +3 lines, -3 lines 0 comments Download
A + chrome/browser/android/offline_pages/offline_page_mhtml_archiver.cc View 1 chunk +1 line, -1 line 0 comments Download
A + chrome/browser/android/offline_pages/offline_page_mhtml_archiver_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
D chrome/browser/offline_pages/offline_page_mhtml_archiver.h View 1 chunk +0 lines, -96 lines 0 comments Download
D chrome/browser/offline_pages/offline_page_mhtml_archiver.cc View 1 chunk +0 lines, -106 lines 0 comments Download
D chrome/browser/offline_pages/offline_page_mhtml_archiver_unittest.cc View 1 chunk +0 lines, -225 lines 0 comments Download
M chrome/chrome_browser.gypi View 1 2 2 chunks +3 lines, -2 lines 0 comments Download
M chrome/chrome_tests_unit.gypi View 1 2 3 chunks +5 lines, -1 line 0 comments Download

Dependent Patchsets:

Messages

Total messages: 10 (4 generated)
fgorski
Is this what you had in mind?
5 years, 5 months ago (2015-07-15 22:27:40 UTC) #1
nyquist
yeah. lgtm. From the look of it though, there are no real chrome dependencies in ...
5 years, 5 months ago (2015-07-17 18:53:18 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1236403003/40001
5 years, 5 months ago (2015-07-17 21:19:21 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1236403003/40001
5 years, 5 months ago (2015-07-17 22:38:58 UTC) #8
commit-bot: I haz the power
Committed patchset #3 (id:40001)
5 years, 5 months ago (2015-07-17 23:35:09 UTC) #9
commit-bot: I haz the power
5 years, 5 months ago (2015-07-17 23:37:23 UTC) #10
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/d170f0f75b7b7e3cac4620816a077d2ae8713751
Cr-Commit-Position: refs/heads/master@{#339356}

Powered by Google App Engine
This is Rietveld 408576698