[Offline Pages] Stub of offline pages bridge

[Offline Pages] Stub of offline pages bridge

BUG=491352
R=nyquist@chromium.org

Committed: https://crrev.com/fd0f0755afb906cc43542b44895a03a854633745
Cr-Commit-Position: refs/heads/master@{#339379}

[fgorski, 2015-07-15 18:23:21]

Please take a look.

This is just a stub, no real code.

[nyquist, 2015-07-17 18:51:31]

lgtm.

One thing to consider would be to only require BrowserContext instead of
Profile. For Android in Java-land you'd have to go through ProfileAndroid
anyway, but that could be used during construction, for example.

https://codereview.chromium.org/1232843003/diff/20001/chrome/android/java/src...
File
chrome/android/java/src/org/chromium/chrome/browser/offline_pages/OfflinePageBridge.java
(right):

https://codereview.chromium.org/1232843003/diff/20001/chrome/android/java/src...
chrome/android/java/src/org/chromium/chrome/browser/offline_pages/OfflinePageBridge.java:25:
public void destroy() {
I seriously don't feel strongly, but maybe there's a presubmit or something that
wants you to document public methods? Just mention that it also destroys native
for example? And that it must be called during destruction?

https://codereview.chromium.org/1232843003/diff/20001/chrome/browser/android/...
File chrome/browser/android/offline_pages/offline_page_bridge.h (right):

https://codereview.chromium.org/1232843003/diff/20001/chrome/browser/android/...
chrome/browser/android/offline_pages/offline_page_bridge.h:19: class
OfflinePageBridge {
A quick explanatory comment as to why this class exists?

[fgorski, 2015-07-17 21:08:33]

Addressed all, including using the browser context on the native side.

https://codereview.chromium.org/1232843003/diff/20001/chrome/android/java/src...
File
chrome/android/java/src/org/chromium/chrome/browser/offline_pages/OfflinePageBridge.java
(right):

https://codereview.chromium.org/1232843003/diff/20001/chrome/android/java/src...
chrome/android/java/src/org/chromium/chrome/browser/offline_pages/OfflinePageBridge.java:25:
public void destroy() {
On 2015/07/17 18:51:31, nyquist wrote:
> I seriously don't feel strongly, but maybe there's a presubmit or something
that
> wants you to document public methods? Just mention that it also destroys
native
> for example? And that it must be called during destruction?

Done.

https://codereview.chromium.org/1232843003/diff/20001/chrome/browser/android/...
File chrome/browser/android/offline_pages/offline_page_bridge.h (right):

https://codereview.chromium.org/1232843003/diff/20001/chrome/browser/android/...
chrome/browser/android/offline_pages/offline_page_bridge.h:19: class
OfflinePageBridge {
On 2015/07/17 18:51:31, nyquist wrote:
> A quick explanatory comment as to why this class exists?

Done.

[fgorski, 2015-07-17 22:45:08]

The CQ bit was checked by fgorski@chromium.org

[fgorski, 2015-07-17 22:45:09]

The patchset sent to the CQ was uploaded after l-g-t-m from nyquist@chromium.org
Link to the patchset: https://codereview.chromium.org/1232843003/#ps40001
(title: "Addressing feedback")

[commit-bot: I haz the power, 2015-07-17 22:47:25]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-07-17 22:47:26]

This CL has an open dependency (Issue 1236403003 Patch 40001). Please resolve
the dependency and try again.

[fgorski, 2015-07-18 00:47:07]

The CQ bit was checked by fgorski@chromium.org

[commit-bot: I haz the power, 2015-07-18 00:47:17]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1232843003/40001

[commit-bot: I haz the power, 2015-07-18 02:10:17]

Committed patchset #3 (id:40001)

[commit-bot: I haz the power, 2015-07-18 02:11:24]

Patchset 3 (id:??) landed as
https://crrev.com/fd0f0755afb906cc43542b44895a03a854633745
Cr-Commit-Position: refs/heads/master@{#339379}