Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1056)

Issue 1235773002: Add jquery and flot to catapult/third_party. (Closed)

Created:
5 years, 5 months ago by qyearsley
Modified:
5 years, 5 months ago
Reviewers:
sullivan
CC:
catapult-reviews_chromium.org
Base URL:
git@github.com:catapult-project/catapult.git@master
Target Ref:
refs/heads/master
Project:
catapult
Visibility:
Public.

Description

Add jquery and flot to catapult/third_party. This is not strictly necessary, since dashboard can always use the CDN versions of jquery and flot. I'm not sure if there's any good reason to do use local copies of jquery and flot except for: - What if the CDN went down or got hijacked? - What if someone wanted to test locally with no network? Thoughts? BUG=488609 Committed: https://chromium.googlesource.com/external/github.com/catapult-project/catapult/+/a43b4c0fcc8c9fb51decc4cf3dd2f4f059ffcc31

Patch Set 1 #

Patch Set 2 : Rebased #

Unified diffs Side-by-side diffs Delta from patch set Stats (+30535 lines, -0 lines) Patch
A third_party/flot/API.md View 1 1 chunk +1498 lines, -0 lines 0 comments Download
A third_party/flot/CONTRIBUTING.md View 1 1 chunk +98 lines, -0 lines 0 comments Download
A third_party/flot/FAQ.md View 1 1 chunk +75 lines, -0 lines 0 comments Download
A third_party/flot/LICENSE.txt View 1 1 chunk +22 lines, -0 lines 0 comments Download
A third_party/flot/Makefile View 1 1 chunk +12 lines, -0 lines 0 comments Download
A third_party/flot/NEWS.md View 1 1 chunk +1026 lines, -0 lines 0 comments Download
A third_party/flot/PLUGINS.md View 1 1 chunk +143 lines, -0 lines 0 comments Download
A third_party/flot/README.chromium View 1 1 chunk +13 lines, -0 lines 0 comments Download
A third_party/flot/README.md View 1 1 chunk +110 lines, -0 lines 0 comments Download
A third_party/flot/excanvas.js View 1 1 chunk +1428 lines, -0 lines 0 comments Download
A third_party/flot/excanvas.min.js View 1 1 chunk +1 line, -0 lines 0 comments Download
A third_party/flot/jquery.js View 1 1 chunk +9472 lines, -0 lines 0 comments Download
A third_party/flot/jquery.colorhelpers.js View 1 1 chunk +180 lines, -0 lines 0 comments Download
A third_party/flot/jquery.colorhelpers.min.js View 1 1 chunk +1 line, -0 lines 0 comments Download
A third_party/flot/jquery.flot.js View 1 1 chunk +3168 lines, -0 lines 0 comments Download
A third_party/flot/jquery.flot.canvas.js View 1 1 chunk +345 lines, -0 lines 0 comments Download
A third_party/flot/jquery.flot.canvas.min.js View 1 1 chunk +7 lines, -0 lines 0 comments Download
A third_party/flot/jquery.flot.categories.js View 1 1 chunk +190 lines, -0 lines 0 comments Download
A third_party/flot/jquery.flot.categories.min.js View 1 1 chunk +7 lines, -0 lines 0 comments Download
A third_party/flot/jquery.flot.crosshair.js View 1 1 chunk +176 lines, -0 lines 0 comments Download
A third_party/flot/jquery.flot.crosshair.min.js View 1 1 chunk +7 lines, -0 lines 0 comments Download
A third_party/flot/jquery.flot.errorbars.js View 1 1 chunk +353 lines, -0 lines 0 comments Download
A third_party/flot/jquery.flot.errorbars.min.js View 1 1 chunk +7 lines, -0 lines 0 comments Download
A third_party/flot/jquery.flot.fillbetween.js View 1 1 chunk +226 lines, -0 lines 0 comments Download
A third_party/flot/jquery.flot.fillbetween.min.js View 1 1 chunk +7 lines, -0 lines 0 comments Download
A third_party/flot/jquery.flot.image.js View 1 1 chunk +241 lines, -0 lines 0 comments Download
A third_party/flot/jquery.flot.image.min.js View 1 1 chunk +7 lines, -0 lines 0 comments Download
A third_party/flot/jquery.flot.min.js View 1 1 chunk +8 lines, -0 lines 0 comments Download
A third_party/flot/jquery.flot.navigate.js View 1 1 chunk +346 lines, -0 lines 0 comments Download
A third_party/flot/jquery.flot.navigate.min.js View 1 1 chunk +7 lines, -0 lines 0 comments Download
A third_party/flot/jquery.flot.pie.js View 1 1 chunk +820 lines, -0 lines 0 comments Download
A third_party/flot/jquery.flot.pie.min.js View 1 1 chunk +7 lines, -0 lines 0 comments Download
A third_party/flot/jquery.flot.resize.js View 1 1 chunk +59 lines, -0 lines 0 comments Download
A third_party/flot/jquery.flot.resize.min.js View 1 1 chunk +7 lines, -0 lines 0 comments Download
A third_party/flot/jquery.flot.selection.js View 1 1 chunk +360 lines, -0 lines 0 comments Download
A third_party/flot/jquery.flot.selection.min.js View 1 1 chunk +7 lines, -0 lines 0 comments Download
A third_party/flot/jquery.flot.stack.js View 1 1 chunk +188 lines, -0 lines 0 comments Download
A third_party/flot/jquery.flot.stack.min.js View 1 1 chunk +7 lines, -0 lines 0 comments Download
A third_party/flot/jquery.flot.symbol.js View 1 1 chunk +71 lines, -0 lines 0 comments Download
A third_party/flot/jquery.flot.symbol.min.js View 1 1 chunk +7 lines, -0 lines 0 comments Download
A third_party/flot/jquery.flot.threshold.js View 1 1 chunk +142 lines, -0 lines 0 comments Download
A third_party/flot/jquery.flot.threshold.min.js View 1 1 chunk +7 lines, -0 lines 0 comments Download
A third_party/flot/jquery.flot.time.js View 1 1 chunk +432 lines, -0 lines 0 comments Download
A third_party/flot/jquery.flot.time.min.js View 1 1 chunk +7 lines, -0 lines 0 comments Download
A third_party/flot/jquery.min.js View 1 1 chunk +5 lines, -0 lines 0 comments Download
A third_party/jquery/README.chromium View 1 1 chunk +13 lines, -0 lines 0 comments Download
A third_party/jquery/jquery-2.1.4.js View 1 1 chunk +9210 lines, -0 lines 0 comments Download
A third_party/jquery/jquery-2.1.4.min.js View 1 1 chunk +4 lines, -0 lines 0 comments Download
A third_party/jquery/jquery-2.1.4.min.map View 1 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 11 (5 generated)
qyearsley
5 years, 5 months ago (2015-07-13 17:00:46 UTC) #2
sullivan
lgtm I think your reasons above are good reasons to have these in 3rd party.
5 years, 5 months ago (2015-07-13 17:03:02 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1235773002/1
5 years, 5 months ago (2015-07-13 17:11:30 UTC) #5
commit-bot: I haz the power
Try jobs failed on following builders: Catapult Windows Tryserver on master.tryserver.client.catapult (JOB_FAILED, https://build.chromium.org/p/tryserver.client.catapult/builders/Catapult%20Windows%20Tryserver/builds/266) (exceeded global ...
5 years, 5 months ago (2015-07-13 17:18:56 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1235773002/10001
5 years, 5 months ago (2015-07-16 17:32:14 UTC) #10
commit-bot: I haz the power
5 years, 5 months ago (2015-07-16 17:38:30 UTC) #11
Message was sent while issue was closed.
Committed patchset #2 (id:10001) as
https://chromium.googlesource.com/external/github.com/catapult-project/catapu...

Powered by Google App Engine
This is Rietveld 408576698