Issue 1235753006: Merge to XFA: Cleanup: Do not check pointers before deleting them, part 2.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 1235753006: Merge to XFA: Cleanup: Do not check pointers before deleting them, part 2. (Closed)

Created:
5 years, 5 months ago by Lei Zhang

Modified:
5 years, 5 months ago

Reviewers:
Tom Sepez

CC:
pdfium-reviews_googlegroups.com

Base URL:
https://pdfium.googlesource.com/pdfium.git@xfa

Target Ref:
refs/heads/xfa

Visibility:
Public.

Merge to XFA: Cleanup: Do not check pointers before deleting them, part 2. R=tsepez@chromium.org Review URL: https://codereview.chromium.org/1195363002 . (cherry picked from commit 21bf242a31eff79f754c5e9c3b41c52e33483bb0) Committed: https://pdfium.googlesource.com/pdfium/+/796c908e7b7bdde819a1e5a4bfd3576d8e8859d6

Created: 5 years, 5 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+32 lines, -101 lines)			Patch
M	core/src/fpdfapi/fpdf_render/fpdf_render.cpp	View	5 chunks	+5 lines, -15 lines	0 comments	Download
M	core/src/fpdfapi/fpdf_render/fpdf_render_image.cpp	View	3 chunks	+7 lines, -21 lines	0 comments	Download
M	core/src/fxcodec/jbig2/JBig2_GeneralDecoder.cpp	View	2 chunks	+3 lines, -9 lines	0 comments	Download
M	core/src/fxge/agg/src/fx_agg_driver.cpp	View	1 chunk	+1 line, -3 lines	0 comments	Download
M	core/src/fxge/android/fpf_skiamodule.cpp	View	1 chunk	+2 lines, -4 lines	0 comments	Download
M	core/src/fxge/apple/fx_mac_imp.cpp	View	1 chunk	+1 line, -3 lines	0 comments	Download
M	core/src/fxge/win32/fx_win32_device.cpp	View	1 chunk	+1 line, -3 lines	0 comments	Download
M	core/src/fxge/win32/fx_win32_dwrite.cpp	View	1 chunk	+1 line, -3 lines	0 comments	Download
M	fpdfsdk/src/formfiller/FFL_ComboBox.cpp	View	1 chunk	+1 line, -5 lines	0 comments	Download
M	fpdfsdk/src/formfiller/FFL_ListBox.cpp	View	1 chunk	+1 line, -5 lines	0 comments	Download
M	fpdfsdk/src/formfiller/FFL_TextField.cpp	View	1 chunk	+1 line, -6 lines	0 comments	Download
M	fpdfsdk/src/fpdf_transformpage.cpp	View	1 chunk	+1 line, -2 lines	0 comments	Download
M	fpdfsdk/src/fpdftext.cpp	View	2 chunks	+2 lines, -9 lines	0 comments	Download
M	fpdfsdk/src/javascript/JS_Context.cpp	View	1 chunk	+1 line, -5 lines	0 comments	Download
M	fpdfsdk/src/javascript/JS_Runtime.cpp	View	1 chunk	+1 line, -2 lines	0 comments	Download
M	fpdfsdk/src/pdfwindow/PWL_FontMap.cpp	View	1 chunk	+3 lines, -6 lines	0 comments	Download

Total messages: 2 (0 generated)

Lei Zhang

5 years, 5 months ago (2015-07-17 01:45:27 UTC) #2

Message was sent while issue was closed.

Committed patchset #1 (id:1) manually as
796c908e7b7bdde819a1e5a4bfd3576d8e8859d6 (presubmit successful).