fpdfsdk/src/formfiller/FFL_ComboBox.cpp - Issue 1235753006: Merge to XFA: Cleanup: Do not check pointers before deleting them, part 2.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: fpdfsdk/src/formfiller/FFL_ComboBox.cpp

Issue 1235753006: Merge to XFA: Cleanup: Do not check pointers before deleting them, part 2. (Closed) Base URL: https://pdfium.googlesource.com/pdfium.git@xfa

Patch Set: Created 5 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: fpdfsdk/src/formfiller/FFL_ComboBox.cpp

diff --git a/fpdfsdk/src/formfiller/FFL_ComboBox.cpp b/fpdfsdk/src/formfiller/FFL_ComboBox.cpp

index 4ceb1e9af389b40242769d6aed941671e1079ce7..b0c7b2d9412e09f606ec0484a5c91296018879ac 100644

--- a/fpdfsdk/src/formfiller/FFL_ComboBox.cpp

+++ b/fpdfsdk/src/formfiller/FFL_ComboBox.cpp

@@ -23,11 +23,7 @@ CFFL_ComboBox::CFFL_ComboBox(CPDFDoc_Environment* pApp, CPDFSDK_Annot* pAnnot) :

CFFL_ComboBox::~CFFL_ComboBox()

{

- if (m_pFontMap)

- {

- delete m_pFontMap;

- m_pFontMap = NULL;

- }

+ delete m_pFontMap;

}

PWL_CREATEPARAM CFFL_ComboBox::GetCreateParam()

« no previous file with comments | « core/src/fxge/win32/fx_win32_dwrite.cpp ('k') | fpdfsdk/src/formfiller/FFL_ListBox.cpp » ('j') | no next file with comments »