Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(931)

Issue 1235673003: Revert of Remove 'blink::WebSerializedOrigin' (1/3) (Closed)

Created:
5 years, 5 months ago by Mike West
Modified:
5 years, 5 months ago
CC:
blink-reviews, dglazkov+blink, peter+watch_chromium.org, tyoshino+watch_chromium.org, yhirano+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Target Ref:
refs/heads/master
Project:
blink
Visibility:
Public.

Description

Revert of Remove 'blink::WebSerializedOrigin' (1/3) (patchset #2 id:20001 of https://codereview.chromium.org/1232563003/) Reason for revert: Blocking the roll; fails on http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_gn_rel/builds/108650 for some reason. :/ Original issue's description: > Remove 'blink::WebSerializedOrigin' (1/3) > > As part of the plan to rationalize Origins across Blink and its embedder, > we're dropping 'blink::WebSerializedOrigin' in favor of > 'blink::WebSecurityOrigin' (which can serialize itself just fine). > > Patch 1 (Blink): This patch. > Patch 2 (Chromium): https://codereview.chromium.org/1229783005 > Patch 3 (Blink): https://codereview.chromium.org/1231643010 > > BUG=508896 > R=jochen@chromium.org > > Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=198731 TBR=jochen@chromium.org,peter@chromium.org NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=508896 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=198733

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+14 lines, -52 lines) Patch
M Source/modules/notifications/Notification.cpp View 4 chunks +4 lines, -3 lines 0 comments Download
M Source/modules/notifications/ServiceWorkerRegistrationNotifications.cpp View 2 chunks +2 lines, -1 line 0 comments Download
M Source/modules/websockets/DocumentWebSocketChannel.cpp View 1 chunk +1 line, -0 lines 0 comments Download
M Source/modules/websockets/DocumentWebSocketChannelTest.cpp View 1 chunk +0 lines, -1 line 0 comments Download
M Source/platform/exported/WebSerializedOrigin.cpp View 2 chunks +0 lines, -6 lines 0 comments Download
M public/platform/WebSerializedOrigin.h View 1 chunk +0 lines, -3 lines 0 comments Download
M public/platform/WebSocketHandle.h View 2 chunks +2 lines, -8 lines 0 comments Download
M public/platform/modules/notifications/WebNotificationManager.h View 4 chunks +5 lines, -30 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
Mike West
Created Revert of Remove 'blink::WebSerializedOrigin' (1/3)
5 years, 5 months ago (2015-07-11 12:50:25 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1235673003/1
5 years, 5 months ago (2015-07-11 12:50:34 UTC) #2
commit-bot: I haz the power
5 years, 5 months ago (2015-07-11 12:51:03 UTC) #3
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://src.chromium.org/viewvc/blink?view=rev&revision=198733

Powered by Google App Engine
This is Rietveld 408576698