Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(197)

Unified Diff: storage/common/blob_storage/blob_item_bytes_request.h

Issue 1234813004: [BlobAsync] Asynchronous Blob Construction Final Patch (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@blob-protocol-change
Patch Set: comments Created 4 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: storage/common/blob_storage/blob_item_bytes_request.h
diff --git a/storage/common/blob_storage/blob_item_bytes_request.h b/storage/common/blob_storage/blob_item_bytes_request.h
index 11a619ce1e21ac53c647fab40bf7be1deecdbeff..3c0e8c764f94ffb4f6424af80a571c325f059bb5 100644
--- a/storage/common/blob_storage/blob_item_bytes_request.h
+++ b/storage/common/blob_storage/blob_item_bytes_request.h
@@ -15,50 +15,51 @@
namespace storage {
// This class is serialized over IPC to request bytes from a blob item.
+// We are using uint32_t for the indexes
struct STORAGE_COMMON_EXPORT BlobItemBytesRequest {
// Not using std::numeric_limits<T>::max() because of non-C++11 builds.
- static const size_t kInvalidIndex = SIZE_MAX;
+ static const uint32_t kInvalidIndex = UINT32_MAX;
static const uint64_t kInvalidSize = UINT64_MAX;
- static BlobItemBytesRequest CreateIPCRequest(size_t request_number,
- size_t renderer_item_index,
- size_t renderer_item_offset,
- size_t size);
+ static BlobItemBytesRequest CreateIPCRequest(uint32_t request_number,
+ uint32_t renderer_item_index,
+ uint64_t renderer_item_offset,
+ uint64_t size);
static BlobItemBytesRequest CreateSharedMemoryRequest(
- size_t request_number,
- size_t renderer_item_index,
- size_t renderer_item_offset,
- size_t size,
- size_t handle_index,
+ uint32_t request_number,
+ uint32_t renderer_item_index,
+ uint64_t renderer_item_offset,
+ uint64_t size,
+ uint32_t handle_index,
uint64_t handle_offset);
- static BlobItemBytesRequest CreateFileRequest(size_t request_number,
- size_t renderer_item_index,
+ static BlobItemBytesRequest CreateFileRequest(uint32_t request_number,
+ uint32_t renderer_item_index,
uint64_t renderer_item_offset,
uint64_t size,
- size_t handle_index,
+ uint32_t handle_index,
uint64_t handle_offset);
BlobItemBytesRequest();
- BlobItemBytesRequest(size_t request_number,
+ BlobItemBytesRequest(uint32_t request_number,
IPCBlobItemRequestStrategy transport_strategy,
- size_t renderer_item_index,
+ uint32_t renderer_item_index,
uint64_t renderer_item_offset,
uint64_t size,
- size_t handle_index,
+ uint32_t handle_index,
uint64_t handle_offset);
~BlobItemBytesRequest();
// The request number uniquely identifies the memory request. We can't use
// the renderer item index or browser item index as there can be multiple
// requests for both (as segmentation boundaries can exist in both).
- size_t request_number;
+ uint32_t request_number;
IPCBlobItemRequestStrategy transport_strategy;
- size_t renderer_item_index;
+ uint32_t renderer_item_index;
uint64_t renderer_item_offset;
uint64_t size;
- size_t handle_index;
+ uint32_t handle_index;
uint64_t handle_offset;
};

Powered by Google App Engine
This is Rietveld 408576698