Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(425)

Unified Diff: storage/common/blob_storage/blob_item_bytes_request.cc

Issue 1234813004: [BlobAsync] Asynchronous Blob Construction Final Patch (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@blob-protocol-change
Patch Set: comments Created 4 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: storage/common/blob_storage/blob_item_bytes_request.cc
diff --git a/storage/common/blob_storage/blob_item_bytes_request.cc b/storage/common/blob_storage/blob_item_bytes_request.cc
index 2f087721e3cf2d25b616627bed3cfe4ec83837dd..a724c435c3679506f501782fa021447a9d519699 100644
--- a/storage/common/blob_storage/blob_item_bytes_request.cc
+++ b/storage/common/blob_storage/blob_item_bytes_request.cc
@@ -10,20 +10,20 @@
namespace storage {
BlobItemBytesRequest BlobItemBytesRequest::CreateIPCRequest(
- size_t request_number,
- size_t renderer_item_index,
- size_t renderer_item_offset,
- size_t size) {
+ uint32_t request_number,
+ uint32_t renderer_item_index,
+ uint64_t renderer_item_offset,
+ uint64_t size) {
return BlobItemBytesRequest(request_number, IPCBlobItemRequestStrategy::IPC,
renderer_item_index, renderer_item_offset, size,
kInvalidIndex, kInvalidSize);
}
BlobItemBytesRequest BlobItemBytesRequest::CreateSharedMemoryRequest(
- size_t request_number,
- size_t renderer_item_index,
- size_t renderer_item_offset,
- size_t size,
- size_t handle_index,
+ uint32_t request_number,
+ uint32_t renderer_item_index,
+ uint64_t renderer_item_offset,
+ uint64_t size,
+ uint32_t handle_index,
uint64_t handle_offset) {
return BlobItemBytesRequest(request_number,
IPCBlobItemRequestStrategy::SHARED_MEMORY,
@@ -32,11 +32,11 @@ BlobItemBytesRequest BlobItemBytesRequest::CreateSharedMemoryRequest(
}
BlobItemBytesRequest BlobItemBytesRequest::CreateFileRequest(
- size_t request_number,
- size_t renderer_item_index,
+ uint32_t request_number,
+ uint32_t renderer_item_index,
uint64_t renderer_item_offset,
uint64_t size,
- size_t handle_index,
+ uint32_t handle_index,
uint64_t handle_offset) {
return BlobItemBytesRequest(request_number, IPCBlobItemRequestStrategy::FILE,
renderer_item_index, renderer_item_offset, size,
@@ -53,12 +53,12 @@ BlobItemBytesRequest::BlobItemBytesRequest()
handle_offset(kInvalidSize) {}
BlobItemBytesRequest::BlobItemBytesRequest(
- size_t request_number,
+ uint32_t request_number,
IPCBlobItemRequestStrategy transport_strategy,
- size_t renderer_item_index,
+ uint32_t renderer_item_index,
uint64_t renderer_item_offset,
uint64_t size,
- size_t handle_index,
+ uint32_t handle_index,
uint64_t handle_offset)
: request_number(request_number),
transport_strategy(transport_strategy),

Powered by Google App Engine
This is Rietveld 408576698