[BlobAsync] Asynchronous Blob Construction Final Patch

storage/common/blob_storage/blob_storage_constants.h

Index: storage/common/blob_storage/blob_storage_constants.h
diff --git a/storage/common/blob_storage/blob_storage_constants.h b/storage/common/blob_storage/blob_storage_constants.h
index e77c8683527875b420adb80fd0b87b357b276dce..d0e1d30a452355d6be1406f4e8e145cfd8817099 100644
--- a/storage/common/blob_storage/blob_storage_constants.h
+++ b/storage/common/blob_storage/blob_storage_constants.h
@@ -32,7 +32,17 @@ enum class IPCBlobCreationCancelCode {
   UNKNOWN = 0,
   OUT_OF_MEMORY,
   FILE_WRITE_FAILED,
-  LAST = FILE_WRITE_FAILED
+  // The renderer was destroyed while data was in transit.
+  SOURCE_DIED_IN_TRANSIT,
+  // The renderer destructed the blob before it was done trasfering, and there

[Mark P, 2016/03/15 18:36:06]

Who reviewed this file?  "trasfering"  really? :-P  Not one but two typos in one
word and the previous reviewer did not catch it?  (Please tell me this file was
supposed to have been reviewed by someone else.  I am only supposed to be
reviewing the usage of metrics; the change has a whole should've already been
reviewed.)

More typos in the comment below.  Please revise them.

[dmurph, 2016/03/15 22:40:14]

These comments were added pretty recently. Typos fixed.

+  // were no outstanding references (no one is waiting to read) to keep the
+  // blob alive.
+  BLOB_DEREFERENCED_WHILE_BUILDING,
+  // A blob that we we referenced during construction is broken, or an
+  // internal tries to build a blob with a blob reference that isn't finished
+  // constructing.
+  REFERENCED_BLOB_BROKEN,
+  LAST = REFERENCED_BLOB_BROKEN

[Mark P, 2016/03/15 18:36:06]

Rather than use +1 in the UMA histogram emit line, I tend to prefer END instead
of LAST, and leave it as the final entry (not with the same value as the
previous entry).  It's up to you though.

[dmurph, 2016/03/15 22:40:14]

Unfortunately I'm also using this enum in IPCs, which use the the 'last = last
enum value' convention, so I have to do a +1 or a -1 somewhere. Since I'm also
using this enum for switch statements (and not using the default keyword because
that can hide bugs), I'd rather keep it this way so I don't have to add another
switch condition.

[Mark P, 2016/03/16 19:25:50]

Acknowledged.

 };
 
 }  // namespace storage