Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(459)

Unified Diff: Source/modules/serviceworkers/ServiceWorkerClients.cpp

Issue 1234603003: CallbackPromiseAdapter types should be more compatible with WebCallbacks (1/3). (Closed) Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: retry! Created 5 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « Source/modules/push_messaging/PushError.cpp ('k') | Source/modules/serviceworkers/ServiceWorkerError.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: Source/modules/serviceworkers/ServiceWorkerClients.cpp
diff --git a/Source/modules/serviceworkers/ServiceWorkerClients.cpp b/Source/modules/serviceworkers/ServiceWorkerClients.cpp
index ae21d1945dc16c533a553b89eefd4fba3627f229..e5cdcaad4dfe65eaf5192e8182ca5951c3abbd6f 100644
--- a/Source/modules/serviceworkers/ServiceWorkerClients.cpp
+++ b/Source/modules/serviceworkers/ServiceWorkerClients.cpp
@@ -16,6 +16,7 @@
#include "modules/serviceworkers/ServiceWorkerWindowClient.h"
#include "public/platform/WebServiceWorkerClientQueryOptions.h"
#include "public/platform/WebServiceWorkerClientsInfo.h"
+#include "wtf/OwnPtr.h"
#include "wtf/PassOwnPtr.h"
#include "wtf/RefPtr.h"
#include "wtf/Vector.h"
@@ -26,8 +27,8 @@ namespace {
class ClientArray {
public:
- typedef WebServiceWorkerClientsInfo WebType;
- static HeapVector<Member<ServiceWorkerClient>> take(ScriptPromiseResolver*, PassOwnPtr<WebType> webClients)
+ using WebType = OwnPtr<WebServiceWorkerClientsInfo>;
+ static HeapVector<Member<ServiceWorkerClient>> take(ScriptPromiseResolver*, PassOwnPtr<WebServiceWorkerClientsInfo> webClients)
{
HeapVector<Member<ServiceWorkerClient>> clients;
for (size_t i = 0; i < webClients->clients.size(); ++i) {
« no previous file with comments | « Source/modules/push_messaging/PushError.cpp ('k') | Source/modules/serviceworkers/ServiceWorkerError.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698