Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(439)

Side by Side Diff: Source/modules/serviceworkers/ServiceWorkerClients.cpp

Issue 1234603003: CallbackPromiseAdapter types should be more compatible with WebCallbacks (1/3). (Closed) Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: retry! Created 5 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
OLDNEW
1 // Copyright 2014 The Chromium Authors. All rights reserved. 1 // Copyright 2014 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "config.h" 5 #include "config.h"
6 #include "modules/serviceworkers/ServiceWorkerClients.h" 6 #include "modules/serviceworkers/ServiceWorkerClients.h"
7 7
8 #include "bindings/core/v8/CallbackPromiseAdapter.h" 8 #include "bindings/core/v8/CallbackPromiseAdapter.h"
9 #include "bindings/core/v8/ScriptPromiseResolver.h" 9 #include "bindings/core/v8/ScriptPromiseResolver.h"
10 #include "core/dom/DOMException.h" 10 #include "core/dom/DOMException.h"
11 #include "core/dom/ExceptionCode.h" 11 #include "core/dom/ExceptionCode.h"
12 #include "core/workers/WorkerGlobalScope.h" 12 #include "core/workers/WorkerGlobalScope.h"
13 #include "core/workers/WorkerLocation.h" 13 #include "core/workers/WorkerLocation.h"
14 #include "modules/serviceworkers/ServiceWorkerError.h" 14 #include "modules/serviceworkers/ServiceWorkerError.h"
15 #include "modules/serviceworkers/ServiceWorkerGlobalScopeClient.h" 15 #include "modules/serviceworkers/ServiceWorkerGlobalScopeClient.h"
16 #include "modules/serviceworkers/ServiceWorkerWindowClient.h" 16 #include "modules/serviceworkers/ServiceWorkerWindowClient.h"
17 #include "public/platform/WebServiceWorkerClientQueryOptions.h" 17 #include "public/platform/WebServiceWorkerClientQueryOptions.h"
18 #include "public/platform/WebServiceWorkerClientsInfo.h" 18 #include "public/platform/WebServiceWorkerClientsInfo.h"
19 #include "wtf/OwnPtr.h"
19 #include "wtf/PassOwnPtr.h" 20 #include "wtf/PassOwnPtr.h"
20 #include "wtf/RefPtr.h" 21 #include "wtf/RefPtr.h"
21 #include "wtf/Vector.h" 22 #include "wtf/Vector.h"
22 23
23 namespace blink { 24 namespace blink {
24 25
25 namespace { 26 namespace {
26 27
27 class ClientArray { 28 class ClientArray {
28 public: 29 public:
29 typedef WebServiceWorkerClientsInfo WebType; 30 using WebType = OwnPtr<WebServiceWorkerClientsInfo>;
30 static HeapVector<Member<ServiceWorkerClient>> take(ScriptPromiseResolver*, PassOwnPtr<WebType> webClients) 31 static HeapVector<Member<ServiceWorkerClient>> take(ScriptPromiseResolver*, PassOwnPtr<WebServiceWorkerClientsInfo> webClients)
31 { 32 {
32 HeapVector<Member<ServiceWorkerClient>> clients; 33 HeapVector<Member<ServiceWorkerClient>> clients;
33 for (size_t i = 0; i < webClients->clients.size(); ++i) { 34 for (size_t i = 0; i < webClients->clients.size(); ++i) {
34 const WebServiceWorkerClientInfo& client = webClients->clients[i]; 35 const WebServiceWorkerClientInfo& client = webClients->clients[i];
35 if (client.clientType == WebServiceWorkerClientTypeWindow) 36 if (client.clientType == WebServiceWorkerClientTypeWindow)
36 clients.append(ServiceWorkerWindowClient::create(client)); 37 clients.append(ServiceWorkerWindowClient::create(client));
37 else 38 else
38 clients.append(ServiceWorkerClient::create(client)); 39 clients.append(ServiceWorkerClient::create(client));
39 } 40 }
40 return clients; 41 return clients;
(...skipping 83 matching lines...) Expand 10 before | Expand all | Expand 10 after
124 resolver->reject(DOMException::create(InvalidAccessError, "Not allowed t o open a window.")); 125 resolver->reject(DOMException::create(InvalidAccessError, "Not allowed t o open a window."));
125 return promise; 126 return promise;
126 } 127 }
127 context->consumeWindowInteraction(); 128 context->consumeWindowInteraction();
128 129
129 ServiceWorkerGlobalScopeClient::from(context)->openWindow(parsedUrl, new Cal lbackPromiseAdapter<ServiceWorkerWindowClient, ServiceWorkerError>(resolver)); 130 ServiceWorkerGlobalScopeClient::from(context)->openWindow(parsedUrl, new Cal lbackPromiseAdapter<ServiceWorkerWindowClient, ServiceWorkerError>(resolver));
130 return promise; 131 return promise;
131 } 132 }
132 133
133 } // namespace blink 134 } // namespace blink
OLDNEW
« no previous file with comments | « Source/modules/push_messaging/PushError.cpp ('k') | Source/modules/serviceworkers/ServiceWorkerError.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698