Source/modules/push_messaging/PushError.cpp - Issue 1234603003: CallbackPromiseAdapter types should be more compatible with WebCallbacks (1/3).

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/modules/push_messaging/PushError.cpp

Issue 1234603003: CallbackPromiseAdapter types should be more compatible with WebCallbacks (1/3). (Closed) Base URL: svn://svn.chromium.org/blink/trunk

Patch Set: retry! Created 5 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: Source/modules/push_messaging/PushError.cpp

diff --git a/Source/modules/push_messaging/PushError.cpp b/Source/modules/push_messaging/PushError.cpp

index 04f5f1de7a39b17d18f217b4ac1bc05c12d6989f..6c0746cec53947187e5b36337320d0db3620b6b6 100644

--- a/Source/modules/push_messaging/PushError.cpp

+++ b/Source/modules/push_messaging/PushError.cpp

@@ -10,7 +10,7 @@

namespace blink {

-DOMException* PushError::take(ScriptPromiseResolver*, PassOwnPtr<WebType> webError)

+DOMException* PushError::take(ScriptPromiseResolver*, PassOwnPtr<WebPushError> webError)

{

switch (webError->errorType) {

case WebPushError::ErrorTypeAbort:

« no previous file with comments | « Source/modules/push_messaging/PushError.h ('k') | Source/modules/serviceworkers/ServiceWorkerClients.cpp » ('j') | no next file with comments »