src/trusted/validator_ragel/instruction_definitions/general_purpose_instructions.def - Issue 1234393005: A mechanism to identify/forbid/"rewrite" non-temporal instructions (and other)

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/trusted/validator_ragel/instruction_definitions/general_purpose_instructions.def

Issue 1234393005: A mechanism to identify/forbid/"rewrite" non-temporal instructions (and other) (Closed) Base URL: https://chromium.googlesource.com/native_client/src/native_client.git@master

Patch Set: Fixing nits Created 5 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« src/trusted/validator_ragel/dfa_validate_common.c ('K') | « src/trusted/validator_ragel/gen_dfa.py ('k') | src/trusted/validator_ragel/instruction_definitions/mmx_instructions.def » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: src/trusted/validator_ragel/instruction_definitions/general_purpose_instructions.def

diff --git a/src/trusted/validator_ragel/instruction_definitions/general_purpose_instructions.def b/src/trusted/validator_ragel/instruction_definitions/general_purpose_instructions.def

index b1848841fe98e72fbae0cc7f98c7ba38ed85cd8a..e2610b0a61330071d9e035b7b924a31f8d278541 100644

--- a/src/trusted/validator_ragel/instruction_definitions/general_purpose_instructions.def

+++ b/src/trusted/validator_ragel/instruction_definitions/general_purpose_instructions.def

@@ -477,7 +477,7 @@ movmskpd Upd Gy, 0x66 0x0f 0x50, CPUFeature_SSE2

# for "Gy" and "Gd" operands. We use objdump's description.

movmskps Ups Gy, 0x0f 0x50, CPUFeature_SSE

######## MOVNTI ################################################################

-movnti Gy My, 0x0f 0xc3, CPUFeature_SSE2

+movnti Gy My, 0x0f 0xc3, CPUFeature_SSE2 nacl-unsupported

######## MOVS/MOVSB/MOVSW/MOVSD/MOVSQ ##########################################

movs X Y, 0xa4, rep nacl-amd64-forbidden

######## MOVSX #################################################################

@@ -616,7 +616,7 @@ prefetch Mb, 0x0f 0x0d /5, CPUFeature_3DPRFTCH no_memory_access nacl-forbidden

prefetch Mb, 0x0f 0x0d /6, CPUFeature_3DPRFTCH no_memory_access nacl-forbidden

prefetch Mb, 0x0f 0x0d /7, CPUFeature_3DPRFTCH no_memory_access nacl-forbidden

######## PREFETCHlevel #########################################################

-prefetchnta Mb, 0x0f 0x18 /0, CPUFeature_SSE no_memory_access

+prefetchnta Mb, 0x0f 0x18 /0, CPUFeature_SSE no_memory_access nacl-unsupported

prefetcht0 Mb, 0x0f 0x18 /1, CPUFeature_SSE no_memory_access

prefetcht1 Mb, 0x0f 0x18 /2, CPUFeature_SSE no_memory_access

prefetcht2 Mb, 0x0f 0x18 /3, CPUFeature_SSE no_memory_access