src/trusted/validator_ragel/instruction_definitions/mmx_instructions.def - Issue 1234393005: A mechanism to identify/forbid/"rewrite" non-temporal instructions (and other)

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/trusted/validator_ragel/instruction_definitions/mmx_instructions.def

Issue 1234393005: A mechanism to identify/forbid/"rewrite" non-temporal instructions (and other) (Closed) Base URL: https://chromium.googlesource.com/native_client/src/native_client.git@master

Patch Set: Fixing nits Created 5 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« src/trusted/validator_ragel/dfa_validate_common.c ('K') | « src/trusted/validator_ragel/instruction_definitions/general_purpose_instructions.def ('k') | src/trusted/validator_ragel/instruction_definitions/xmm_instructions.def » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: src/trusted/validator_ragel/instruction_definitions/mmx_instructions.def

diff --git a/src/trusted/validator_ragel/instruction_definitions/mmx_instructions.def b/src/trusted/validator_ragel/instruction_definitions/mmx_instructions.def

index 5b2ffbf335b347c5a3f28e1d41776e6831410bc4..426b77f3a37f8fd7ee24cac85c403b75488f69b1 100644

--- a/src/trusted/validator_ragel/instruction_definitions/mmx_instructions.def

+++ b/src/trusted/validator_ragel/instruction_definitions/mmx_instructions.def

@@ -46,7 +46,7 @@ movd Pq Ed, 0x0f 0x7e, norexw CPUFeature_MMX nacl-amd64-zero-extends

movq Eq Pq, rexw 0x0f 0x6e, amd64 CPUFeature_MMX

movq Pq Eq, rexw 0x0f 0x7e, amd64 CPUFeature_MMX

######## MOVNTQ ################################################################

-movntq Pq Mq, 0x0f 0xe7, CPUFeature_EMMXSSE

+movntq Pq Mq, 0x0f 0xe7, CPUFeature_EMMXSSE nacl-unsupported

######## MOVQ ##################################################################

movq Qq Pq, 0x0f 0x6f, CPUFeature_MMX

movq Pq Qq, 0x0f 0x7f, CPUFeature_MMX