Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(258)

Issue 1234393002: Revert of Precompile more in Blink in Windows for faster compilations (Closed)

Created:
5 years, 5 months ago by Daniel Bratell
Modified:
5 years, 5 months ago
CC:
blink-reviews, blink-reviews-wtf_chromium.org, Mikhail, haraken, tasak (please_use_google.com)
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Target Ref:
refs/heads/master
Project:
blink
Visibility:
Public.

Description

Revert of Precompile more in Blink in Windows for faster compilations (patchset #9 id:160001 of https://codereview.chromium.org/1167523007/) Reason for revert: Strange errors in http://build.chromium.org/p/chromium.fyi/builders/Chromium%20Builder indicating that old versions of headers are used by the compiler. Possibly a stale cached pch file. Original issue's description: > Precompile more in Blink in Windows for faster compilations > > One reason Blink is slow to compile is that there is a lot of code > included in every compilation unit since everything depends on either > LayoutObject.h or Document.h and those in turn include huge portions > of the rest of Blink. > > By precompiling LayoutObject.h and Document.h the compilation of core and > modules in Blink can be 4 times faster (4 minutes instead of > 19 minutes on my computer). > > The downside is that it will introduce Document.h and LayoutObject.h > also in compilation units that didn't expect it, for instance > XPathGrammer.y that suddenly will have both blink::Path and > blink::XPath::Path in scope (and blink::Filter / blink::XPath::Filter) > > Note that distributed compilation system disables precompiled headers > globally so this will *not* make trybots faster. > > BUG=495697 > R=thakis@chromium.org > > Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=198859 TBR=brucedawson@chromium.org,jam@chromium.org,scottmg@chromium.org,thakis@chromium.org,sigbjornf@opera.com,tasak@google.com,haraken@chromium.org NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=495697 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=199036

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+9 lines, -86 lines) Patch
M Source/core/DEPS View 1 chunk +0 lines, -1 line 0 comments Download
M Source/core/core.gyp View 4 chunks +4 lines, -4 lines 0 comments Download
M Source/core/frame/Frame.h View 2 chunks +1 line, -1 line 0 comments Download
D Source/core/win/Precompile-core.h View 1 chunk +0 lines, -33 lines 0 comments Download
D Source/core/win/Precompile-core.cpp View 1 chunk +0 lines, -9 lines 0 comments Download
D Source/core/win/precompile-core.gypi View 1 chunk +0 lines, -29 lines 0 comments Download
M Source/core/xml/XPathGrammar.y View 2 chunks +3 lines, -3 lines 0 comments Download
M Source/modules/modules.gyp View 1 chunk +1 line, -1 line 0 comments Download
M Tools/Scripts/webkitpy/style/checkers/cpp.py View 1 chunk +0 lines, -5 lines 0 comments Download

Messages

Total messages: 15 (4 generated)
Daniel Bratell
Created Revert of Precompile more in Blink in Windows for faster compilations
5 years, 5 months ago (2015-07-16 15:23:16 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1234393002/1
5 years, 5 months ago (2015-07-16 15:28:32 UTC) #3
commit-bot: I haz the power
No L-G-T-M from a valid reviewer yet. Only full committers are accepted. Even if an ...
5 years, 5 months ago (2015-07-16 15:28:36 UTC) #5
Nico
lgtm
5 years, 5 months ago (2015-07-16 15:34:25 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1234393002/1
5 years, 5 months ago (2015-07-16 15:35:04 UTC) #8
commit-bot: I haz the power
Committed patchset #1 (id:1) as https://src.chromium.org/viewvc/blink?view=rev&revision=199036
5 years, 5 months ago (2015-07-16 15:35:57 UTC) #9
philipj_slow
lgtm Removed these bits so that it'll go through CQ and not break everything more: ...
5 years, 5 months ago (2015-07-16 15:35:58 UTC) #11
philipj_slow
On 2015/07/16 15:35:58, philipj wrote: > lgtm > > Removed these bits so that it'll ...
5 years, 5 months ago (2015-07-16 15:36:25 UTC) #12
sof
The reverted CL was Blink r19859. Builds [43921, 43963] seems to have built fine with ...
5 years, 5 months ago (2015-07-16 16:59:39 UTC) #13
sof
On 2015/07/16 16:59:39, sof wrote: > The reverted CL was Blink r19859. > > Builds ...
5 years, 5 months ago (2015-07-16 17:00:17 UTC) #14
Daniel Bratell
5 years, 5 months ago (2015-07-17 14:04:03 UTC) #15
Message was sent while issue was closed.
A revert of this CL (patchset #1 id:1) has been created in
https://codereview.chromium.org/1227953008/ by bratell@opera.com.

The reason for reverting is: Again.

Powered by Google App Engine
This is Rietveld 408576698