Tools/Scripts/webkitpy/style/checkers/cpp.py - Issue 1234393002: Revert of Precompile more in Blink in Windows for faster compilations

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Tools/Scripts/webkitpy/style/checkers/cpp.py

Issue 1234393002: Revert of Precompile more in Blink in Windows for faster compilations (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: Created 5 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: Tools/Scripts/webkitpy/style/checkers/cpp.py

diff --git a/Tools/Scripts/webkitpy/style/checkers/cpp.py b/Tools/Scripts/webkitpy/style/checkers/cpp.py

index 6343113dc91cea7d91fb66be2fab87dd683f1eb6..bac6adce8d3850446e65e5cb1d9007ff559b3849 100644

--- a/Tools/Scripts/webkitpy/style/checkers/cpp.py

+++ b/Tools/Scripts/webkitpy/style/checkers/cpp.py

@@ -3156,11 +3156,6 @@

error_message = include_state.check_next_include_order(header_type,

file_extension == "h",

primary_header_exists)

- # Normally including a _CONFIG_HEADER in another header file would be an error

- # but not when included in a precompile header since that one will need it.

- if error_message and "config.h" in error_message and "precompile" in filename.lower():

- error_message = None

# Check to make sure we have a blank line after primary header.

if not error_message and header_type == _PRIMARY_HEADER:

« no previous file with comments | « Source/modules/modules.gyp ('k') | no next file » | no next file with comments »