Simplify InputMethodWin initialization.

Simplify InputMethodWin initialization.

 1) Removes the "active" state of InputMethod.
 2) Removes RenderWidget::input_method_is_active_, and allows IPCs when system IME is not active.
 3) Removes COM dependency in InputMethodWin.

TBR=erg@chromium.org
BUG=296509, 471580, 474828
TEST=On locally builds, makes sure no regressions when typing text with/without system IMEs activated.

Committed: https://crrev.com/4c937892ddf18a7246e682b4885af55a050ad962
Cr-Commit-Position: refs/heads/master@{#339408}

[Shu Chen, 2015-07-15 07:27:47]

shuchen@chromium.org changed reviewers:
+ suzhe@chromium.org, yukawa@chromium.org

[Shu Chen, 2015-07-15 07:27:48]

James/Yohei, can you please review this cl? Thanks

[James Su, 2015-07-15 08:08:39]

lgtm

[yukawa, 2015-07-15 08:27:13]

I have no strong objection to this CL but I think what I wanted to do in Issue
471580 was to get rid of the dependency on COM.  The number of COM object
creations doesn't matter.

[Shu Chen, 2015-07-15 08:32:22]

On 2015/07/15 08:27:13, yukawa wrote:
> I have no strong objection to this CL but I think what I wanted to do in Issue
> 471580 was to get rid of the dependency on COM.  The number of COM object
> creations doesn't matter.

The COM dependency cannot be removed because it is needed for detecting active
state.
As mentioned in crbug.com/296509, |RenderWidget::input_method_is_active_| is
still working to avoid unnecessary IPCs.
And RenderWidget requires the knowledge about whether the system ime is
activated.

[Shu Chen, 2015-07-16 09:23:24]

Hi yukawa@, I've uploaded a new patchset cover crbug.com/296509.

Can you please take a look? Thanks

[Shu Chen, 2015-07-17 02:31:47]

The CQ bit was checked by shuchen@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2015-07-17 02:33:23]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1234193002/80001

[commit-bot: I haz the power, 2015-07-17 02:43:09]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-07-17 02:43:10]

Dry run: Try jobs failed on following builders:
  android_chromium_gn_compile_dbg on tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/android_chromiu...)

[Shu Chen, 2015-07-17 04:07:17]

The CQ bit was checked by shuchen@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2015-07-17 04:07:24]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1234193002/100001

[Shu Chen, 2015-07-17 04:09:02]

shuchen@chromium.org changed reviewers:
+ avi@chromium.org, nasko@chromium.org, sadrul@chromium.org

[Shu Chen, 2015-07-17 04:09:02]

+nasko@ for content/common/view_messages.h.

+avi@ for content/renderer/render_widget.*.

+sadrul@ for content/browser/...

[commit-bot: I haz the power, 2015-07-17 04:21:06]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-07-17 04:21:07]

Dry run: Try jobs failed on following builders:
  win8_chromium_ng on tryserver.chromium.win (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.win/builders/win8_chromium_ng/...)

(exceeded global retry quota)

[Shu Chen, 2015-07-17 04:34:48]

The CQ bit was checked by shuchen@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2015-07-17 04:35:12]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1234193002/120001

[commit-bot: I haz the power, 2015-07-17 04:43:41]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-07-17 04:43:43]

Dry run: Try jobs failed on following builders:
  linux_chromium_gn_dbg on tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

(exceeded global retry quota)

[Avi (use Gerrit), 2015-07-17 04:45:48]

content/renderer/render_widget.* lgtm

The TEST= line isn't about how you tested it (surely you did) but how someone
could test it. Please change that line to describe how one might do so, or
remove it if not applicable.

(see
https://www.chromium.org/developers/contributing-code#TOC-Change-List-Descrip...
)

[Shu Chen, 2015-07-17 05:42:45]

The CQ bit was checked by shuchen@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2015-07-17 05:42:55]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1234193002/140001

[yukawa, 2015-07-17 07:50:37]

LGTM with one minor comment.

https://codereview.chromium.org/1234193002/diff/160001/ui/base/ime/win/imm32_...
File ui/base/ime/win/imm32_manager.cc (right):

https://codereview.chromium.org/1234193002/diff/160001/ui/base/ime/win/imm32_...
ui/base/ime/win/imm32_manager.cc:7: #include <msctf.h>
nit: Can we remove this line?

[Shu Chen, 2015-07-17 08:21:05]

On 2015/07/17 04:45:48, Avi wrote:
> content/renderer/render_widget.* lgtm
> 
> The TEST= line isn't about how you tested it (surely you did) but how someone
> could test it. Please change that line to describe how one might do so, or
> remove it if not applicable.
> 
> (see
>
https://www.chromium.org/developers/contributing-code#TOC-Change-List-Descrip...
> )

Thanks. I've updated the TEST= line.

[Shu Chen, 2015-07-17 08:22:00]

https://codereview.chromium.org/1234193002/diff/160001/ui/base/ime/win/imm32_...
File ui/base/ime/win/imm32_manager.cc (right):

https://codereview.chromium.org/1234193002/diff/160001/ui/base/ime/win/imm32_...
ui/base/ime/win/imm32_manager.cc:7: #include <msctf.h>
On 2015/07/17 07:50:36, yukawa wrote:
> nit: Can we remove this line?

Done.

[Shu Chen, 2015-07-17 08:22:18]

The CQ bit was checked by shuchen@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2015-07-17 08:22:33]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1234193002/180001

[commit-bot: I haz the power, 2015-07-17 09:29:47]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-07-17 09:29:48]

Dry run: This issue passed the CQ dry run.

[nasko, 2015-07-17 09:53:39]

IPC removal LGTM!

[sadrul, 2015-07-19 01:16:47]

stamp lgtm

[Shu Chen, 2015-07-19 09:22:42]

The CQ bit was checked by shuchen@chromium.org

[Shu Chen, 2015-07-19 09:22:42]

The patchset sent to the CQ was uploaded after l-g-t-m from suzhe@chromium.org,
avi@chromium.org, yukawa@chromium.org
Link to the patchset: https://codereview.chromium.org/1234193002/#ps180001
(title: " ")

[commit-bot: I haz the power, 2015-07-19 09:22:46]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1234193002/180001

[commit-bot: I haz the power, 2015-07-19 09:31:45]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-07-19 09:31:46]

Try jobs failed on following builders:
  chromium_presubmit on tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presub...)

[Shu Chen, 2015-07-19 09:34:20]

TBR'ing erg@ for trivial changes under mandoline/...

[Shu Chen, 2015-07-19 09:34:30]

The CQ bit was checked by shuchen@chromium.org

[commit-bot: I haz the power, 2015-07-19 09:34:39]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1234193002/180001

[commit-bot: I haz the power, 2015-07-19 10:33:23]

Committed patchset #10 (id:180001)

[commit-bot: I haz the power, 2015-07-19 10:34:32]

Patchset 10 (id:??) landed as
https://crrev.com/4c937892ddf18a7246e682b4885af55a050ad962
Cr-Commit-Position: refs/heads/master@{#339408}

[jdduke (slow), 2015-07-22 20:40:58]

jdduke@chromium.org changed reviewers:
+ jdduke@chromium.org

[jdduke (slow), 2015-07-22 20:40:59]

https://codereview.chromium.org/1234193002/diff/180001/content/renderer/rende...
File content/renderer/render_widget.cc (left):

https://codereview.chromium.org/1234193002/diff/180001/content/renderer/rende...
content/renderer/render_widget.cc:1922: #endif
It would be really nice if we could reland your merger of
UpdateTextInputType/State (https://codereview.chromium.org/326403002). Is there
a reason that hasn't pushed forward? We're paying for this IPC on Android even
though it goes completely unused.

[Shu Chen, 2015-07-23 00:57:46]

https://codereview.chromium.org/1234193002/diff/180001/content/renderer/rende...
File content/renderer/render_widget.cc (left):

https://codereview.chromium.org/1234193002/diff/180001/content/renderer/rende...
content/renderer/render_widget.cc:1922: #endif
On 2015/07/22 20:40:59, jdduke wrote:
> It would be really nice if we could reland your merger of
> UpdateTextInputType/State (https://codereview.chromium.org/326403002). Is
there
> a reason that hasn't pushed forward? We're paying for this IPC on Android even
> though it goes completely unused.

CL https://codereview.chromium.org/326403002 got reverted due to
crbug.com/417152, of which the comment #13 tells the root cause which was due to
the |input_method_is_active_| flag here. So UpdateTextInputType() always does
the thing on Windows, but UpdateTextInputState() doesn't.

After this CL, I think it would be safe to reland
https://codereview.chromium.org/326403002.